Calling an unknown tool logs a server-side Error "threw an unhandled exception"

未關閉
#2,030 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
75/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
csharp

研究方向

Start in src/ModelContextProtocol.Core/Server/McpServerImpl.cs, tracing the unknown-tool handler and the BuildInitialAlternateToolFilter and LogToolCallLifecycles paths that call ToolCallError. Compare this path with the existing Logs_Tool_Error_When_Tool_Throws_McpProtocolException test. Done means an unknown tool still returns JSON-RPC -32602 without an Error log, while an exception thrown by a tool remains logged at Error.

由索引模型根據 Issue 內容生成。

描述

Summary

When a client calls a tool that does not exist, the server answers correctly with JSON-RPC -32602 (Unknown tool: '…'), but it also writes a server-side Error with a stack trace:

fail: "no_such_tool" threw an unhandled exception.
ModelContextProtocol.McpProtocolException: Unknown tool: 'no_such_tool'

The cause is input from the client, not a fault of the server, yet it looks like a crash in logs, APM and alerting. Any client (or a model that hallucinates a tool name) can produce these Errors at will.

Where (2.4.0, unchanged on main)

src/ModelContextProtocol.Core/Server/McpServerImpl.cs

  • The default handler throws new McpProtocolException($"Unknown tool: '{name}'", McpErrorCode.InvalidParams) (line ~1603).
  • BuildInitialAlternateToolFilter (line ~1737) and LogToolCallLifecycles (line ~1787) call ToolCallError (LogLevel.Error, "threw an unhandled exception.") for every exception except cancellation and InputRequiredException, including this McpProtocolException, and then rethrow it as the protocol error.

Reproduction

Server with any tool, client calls tools/call with the name no_such_tool. Expected: -32602 to the client, no Error on the server. Actual: -32602 and the Error above.

Context

Logs_Tool_Error_When_Tool_Throws_McpProtocolException asserts that an McpProtocolException thrown by a tool is logged at Error, so I understand that is intended. The unknown-tool case is different: no tool ran, and the exception comes from the SDK's own validation of the request.

Proposal

Do not log ToolCallError when no tool was matched for the request (the SDK's own unknown-tool path), or log it at Debug/Information like ToolCallCompleted. The protocol error to the client stays as it is.

Workaround we use today: an incoming message filter (WithMessageFilters(f => f.AddIncomingFilter(...))) that answers tools/call for unknown names with -32602 before the tool pipeline runs. Happy to send a PR if the direction is acceptable.

主要語言
C#
星號
4.6k
分支
849
平均合併
1 天 16 小時
30 天內合併 PR
24

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

modelcontextprotocol/csharp-sdk 的其他 Issue

查看 modelcontextprotocol/csharp-sdk 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。