coverage: MiniMax-M3 has no AVAILABLE rows
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1054 by @juliankang4 — merged
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- backend, machine-learning
Research direction
Read crates/model/src/arch/coverage.rs around lines 48 and 1854, then compare the MiniMax-M3 placement logic in crates/model/src/arch/minimaxm3/place.rs around line 213 with the shared coverage rows. Check the supported BlockMax shapes and how coverage tests represent supported and unsupported operation needs. Done means supported needs are covered, unsupported needs remain listed, and unrelated unsupported chat features are not required to pass.
Written by the indexing model from the issue text.
Description
program_of(MiniMaxM3) returns MiniMaxM3Body, but AVAILABLE contains no row naming that program and no BlockMax row. check_with requires a matching program for each operation, so PlanInputs::unimplemented reports implemented MiniMax operations as missing, including sparse attention in gpu-minimaxm3::attn. PlanInputs::read propagates these false operation-coverage refusals. Add the program to the shared rows its kernels implement and add its supported BlockMax shapes. Add a regression that supported operation needs are covered while unsupported needs remain listed; do not require unrelated unsupported chat features to pass.
Evidence (at the base of #802):
- crates/placement/src/accepts.rs:82
- crates/model/src/arch/coverage.rs:48
- crates/model/src/arch/coverage.rs:1854
- crates/model/src/arch/place_hybrid.rs:420
- crates/model/src/arch/minimaxm3/place.rs:213
- crates/gpu-minimaxm3/src/attn.rs:1
Filed by Shingler, the review bot, while reviewing #802; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 2h 31m
- Merged PRs (30d)
- 828
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
good first issue hardware help wanted no-box serve
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
good first issue hardware help wanted no-box
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
midagedev/bloomery#863 · 4 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 10/100
midagedev/bloomery#1165 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
midagedev/bloomery#1163 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
midagedev/bloomery#1162 · 8 comments ·
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
rust_analyzer flycheck: no CLI way to enable clippy from `check.overrideCommand`Possibly taken @TrapsterDK claimed this today. Openneeds-triage
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
bazelbuild/rules_rust#4392 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
🐞 bug 🧩 bevy_gantz_egui
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
nannou-org/gantz#500 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
metasequoiaime/msime#10989 ·
Maintainers usually reply within 1 day