ref builders: failed git status is accepted as a clean source tree
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
The same check is in tools/ref/build-hidden.sh (around line 21), tools/ref/build-nemotron-ref.sh (around line 19) and tools/ref/clefvis/build-clefvis.sh (around line 31). Start by reading how each script tests the output of git status inside a command substitution, then reproduce by stubbing git status to exit 128. Done when all three scripts exit non-zero on that failure, with the status captured in a standalone assignment before its output is tested.
Written by the indexing model from the issue text.
Description
The hidden, nemotron and clefvis builders put git status inside a test's command substitution. A corrupt or unreadable Git index makes status exit 128 with empty stdout. The test then treats the tree as clean. rev-parse HEAD does not need that index, so the scripts can compile unchecked headers and record the commit as their provenance. Validation reproduced exit 0 after a status stub returned 128; the standalone assignment exited 128. Capture git status in a standalone assignment before testing its output; set -e then stops on failure.
Evidence (at the base of #242):
- tools/ref/build-hidden.sh:21
- tools/ref/build-nemotron-ref.sh:19
- tools/ref/clefvis/build-clefvis.sh:31
Filed by Shingler, the review bot, while reviewing #242; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 3h 27m
- Merged PRs (30d)
- 194
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
review-bot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
midagedev/bloomery#318 · 1 comment ·
Maintainers usually reply within 1 day
-
review-bot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
review-bot
Difficulty 2/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
review-bot
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
area: compat area: parsing bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
reubeno/brush#1526 · 1 comment ·
Maintainers usually reply within 1 day
-
OFN writer emits `DocIRI` as a bare IRI, which becomes a version IRI or a parse error on re-readOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
phillord/horned-owl#338 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
stackabletech/operator-rs#1301 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
jmcnamara/rust_xlsxwriter#205 · 4 comments ·