gpu-gates: chain FFN gate duplicates the shared rounding model
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Newbie friendliness
- 78/100
Research direction
Start at crates/gpu-gates/src/bin/gate_deepseek41_chain_ffn.rs, lines 149 and 152, where the local U and gamma are defined, then compare them with the shared definitions in crates/gpu-gates/src/rounding.rs at lines 10 and 17. Replace the local copies with an import of bloomery_gpu_gates::rounding::{U, gamma} and check that the binary still builds. Done means both local definitions are gone and the crate compiles unchanged in behaviour.
Written by the indexing model from the issue text.
Description
gate_deepseek41_chain_ffn.rs:149 defines U and :152 defines gamma locally. They reproduce the f32 unit roundoff and gamma(n) formula already owned by rounding.rs:10 and :17 (R14). Import bloomery_gpu_gates::rounding::{U, gamma} and delete the local definitions. This removes two duplicate definitions without adding a dependency.
Evidence (at the base of #237):
- crates/gpu-gates/src/bin/gate_deepseek41_chain_ffn.rs:149
- crates/gpu-gates/src/bin/gate_deepseek41_chain_ffn.rs:152
- crates/gpu-gates/src/rounding.rs:17
Filed by Shingler, the review bot, while reviewing #237; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 3h 52m
- Merged PRs (30d)
- 134
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
hidden_ref: invalid numeric options silently select defaultsPossibly taken @midagedev claimed this today. Openreview-bot
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
Maintainers usually reply within 1 day
-
review-bot
Difficulty 3/5 1-2 days Newbie friendliness 56/100
midagedev/bloomery#214 · 1 comment ·
Maintainers usually reply within 1 day
-
model new-model
Difficulty 5/5 Over a week Newbie friendliness 5/100
midagedev/bloomery#190 · 2 comments ·
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
agent:triaged bug bughunt pm:bundler priority:p1
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
SocketDev/socket-patch#1573 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
bytecodealliance/rustix#1706 · 1 comment ·
Maintainers usually reply within 11 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
wormhole-foundation/wormhole#5062 ·
Maintainers usually reply within 1 day
-
LaunchOrFocusPlugin switches to the wrong tab after tabs are reordered (tab id used as position)Possibly taken @olegator888 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
zellij-org/zellij#5719 ·
Maintainers usually reply within 1 day