gpu-gates: selected-slot greedy stepping has two owners
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
Research direction
Two copies of the same greedy-stepping helper live in crates/gpu-gates/src/slots_gate.rs:608 and crates/gpu-gates/src/bin/gate_qwen35moe_e2e.rs:2527; read both to confirm they are identical and note that Body35 implements ChainBody so the generic helper accepts the Qwen35moeModel caller. Make the slots_gate helper public while keeping its doc sentence, delete the binary's copy and have it call the shared helper. Done means one implementation, the doc comment preserved, and the gpu-gates tests still passing.
Written by the indexing model from the issue text.
Description
The base has the same generation rule in slots_gate.rs:608 and gate_qwen35moe_e2e.rs:2527. Both take an existing model and id vector, feed the last id through model.step exactly n times, append each result, and reject an empty vector before taking a step. Qwen35moeModel is GpuModel, and Body35 implements ChainBody, so the generic helper supports that caller. Neither function is changed by the incremental diff. This is a proven duplicate under R14. Expose the slots_gate helper, retain its doc sentence, remove the binary's copy, and route its call through the shared helper.
Evidence (at the base of #125):
Filed by Shingler, the review bot, while reviewing #125; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 3h 52m
- Merged PRs (30d)
- 134
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
review-bot
Difficulty 2/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
hidden_ref: invalid numeric options silently select defaultsPossibly taken @midagedev claimed this today. Openreview-bot
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
Maintainers usually reply within 1 day
-
review-bot
Difficulty 3/5 1-2 days Newbie friendliness 56/100
midagedev/bloomery#214 · 1 comment ·
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
wormhole-foundation/wormhole#5062 ·
Maintainers usually reply within 1 day
-
RUSTSEC-2026-0348: Brotli certificate decompression can allocate up to 1 GiB before authenticationOpen
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 62/100
-
core: Amount::from_str panics on values above 21M BTC instead of returning an errorPossibly taken @bhuvan-somisetty claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
crate: spate-s3
Difficulty 2/5 Half a day Newbie friendliness 62/100
Maintainers usually reply within 1 day