Improve execution time on Model deserialization
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- api, performance
Research direction
Start by tracing the SDK's model deserialization after the REST response, which the issue identifies as the main source of overhead. Reproduce the reported comparison for the me, users, and domains endpoints; done means demonstrating a measurable reduction in execution time against raw API calls.
Written by the indexing model from the issue text.
Description
So I tried to migrate our usage of raw API calls to Microsoft Graph to your new release 1.1.0.
And I measured execution time with the bare-bones method time.time() before method call, time.time() after method call.
I've tried performing get requests for the endpoints: me, users, domains.
The results were that the sdk is on average 3.5 times slower than the raw call to API which I think a great deal.
Furthermore, I was curios where this overhead came from and I searched through the code with debug.
And the most time spent in execution is after the call to the rest api, when the sdk is building a model by deserializing the json object got from the request in a sdk specific object.
This execution time difference lead me to decide that I should postpone the migration until this is improved or fixed.
- Dominant language
- Python
- Stars
- 630
- Forks
- 96
- Avg merge
- 15h 20m
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoftgraph/msgraph-sdk-python
-
status:waiting-for-triage type:bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
microsoftgraph/msgraph-sdk-python#1570 ·
-
status:waiting-for-triage type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoftgraph/msgraph-sdk-python#1563 ·
-
Needs: Attention :wave: type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoftgraph/msgraph-sdk-python#1287 · 2 comments · 1 reaction ·
-
status:waiting-for-triage type:bug
Difficulty 3/5 1-2 days Newbie friendliness 52/100
microsoftgraph/msgraph-sdk-python#1578 ·
-
status:waiting-for-triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
microsoftgraph/msgraph-sdk-python#1557 ·
All issues in microsoftgraph/msgraph-sdk-python
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
canonical/paas-charm#368 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
tech debt
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
StevenBlack/hosts#3256 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
qualcomm/qai-appbuilder#275 ·