Regression: CreateLinkPostRequestBody serializes retainInheritedPermissions=false by default starting in 1.59.2
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start with the generated CreateLinkPostRequestBody entry point shown in the import path and reproduce serialization using the test.py example. Compare the output with versions 1.58.0 and 1.59.2, focusing on omitted retainInheritedPermissions and sendNotification values. Done means unset properties no longer serialize false values, allowing the createLink API defaults to apply.
Written by the indexing model from the issue text.
Description
Describe the bug
Context
I was using the CreateLinkPostRequestBody to create some link to my driveItems, and it was working properly, but at some point I noticed that some of these files would not be visible to some users anymore (inherited permissions were lost).
The "bug"
Starting with msgraph-sdk-python 1.59.2, CreateLinkPostRequestBody serializes: { "retainInheritedPermissions": false, "sendNotification": false } when these properties are not explicitly set by the caller.
This changes the behavior of the createLink API. According to the Microsoft Graph documentation, retainInheritedPermissions is optional and the service default when omitted is true .
Expected behavior
I believe that the CreateLinkPostRequestBody default attribute values should follow the defaults of the createLink API.
Thus setting retainInheritedPermissions to true (or unset) for the createLink API if not provided in CreateLinkPostRequestBody.
How to reproduce
test.py
from msgraph.generated.drives.item.items.item.create_link.create_link_post_request_body import CreateLinkPostRequestBody
request_body = CreateLinkPostRequestBody(
type="view",
scope="organization"
)
from kiota_serialization_json.json_serialization_writer import JsonSerializationWriter
writer = JsonSerializationWriter()
request_body.serialize(writer)
print(writer.get_serialized_content().decode('utf-8'))
Results
version 1.58.0
{
"scope": "organization",
"type": "view"
}
This will let the createLink API default the retainInheritedPermissions to True.
version 1.59.2 and 1.60.0
{
"retainInheritedPermissions": false,
"scope": "organization",
"sendNotification": false,
"type": "view"
}
This will remove existing permissions.
SDK Version
1.59.2
Latest version known to work for scenario above?
1.58.0
Known Workarounds
Explicitly adding the retain_inherited_permissions = True
request_body = CreateLinkPostRequestBody(
retain_inherited_permissions=True,
type="view",
scope="organization"
)
Debug output
Click to expand log
```</details>
### Configuration
Ubuntu 22.04
x86_64
### Other information
_No response_
- Dominant language
- Python
- Stars
- 634
- Forks
- 100
- Avg merge
- 23h 18m
- Merged PRs (30d)
- 7
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoftgraph/msgraph-sdk-python
-
status:waiting-for-triage type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
microsoftgraph/msgraph-sdk-python#1628 ·
Maintainers usually reply within 1 day
-
status:waiting-for-triage type:bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
microsoftgraph/msgraph-sdk-python#1570 ·
Maintainers usually reply within 1 day
-
kiota-dom-export.txt is large and included in the released packagePossibly taken @Fryguy claimed this 184 days ago. OpenNeeds: Attention :wave: type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoftgraph/msgraph-sdk-python#1287 · 3 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
status:waiting-for-triage type:feature
Difficulty 5/5 Over a week Newbie friendliness 25/100
microsoftgraph/msgraph-sdk-python#1596 ·
Maintainers usually reply within 1 day
-
status:waiting-for-triage type:bug
Difficulty 3/5 1-2 days Newbie friendliness 52/100
microsoftgraph/msgraph-sdk-python#1578 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in microsoftgraph/msgraph-sdk-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
trycua/hermes-cua-spaces#17 ·
-
area:codegen backend:hip bug direction:output good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
nautechsystems/nautilus_trader#5718 ·
Maintainers usually reply within 1 day
-
[Bug]: reme CLI crashes when the running server used a relative config pathPossibly taken @nurlanmnn claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
agentscope-ai/ReMe#770 ·
Maintainers usually reply within 1 day
-
Pi: paused model calls are reported as "not signed in" when the model's provider comes from an extensionPossibly taken @balcsida claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
microsoft/TokenEconomizer#288 ·
Maintainers usually reply within 1 day