[Feature] Prevent getWSEndpoint from returning undefined
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- devtools
Research direction
Start by locating DebuggerEndpointHelper.getWSEndpoint and trace how the /json/list response and existing Metro fallback are handled. Verify behavior for invalid targets, selection of the first valid target, fallback when none are valid, and a clear error when no target can be found.
Written by the indexing model from the issue text.
Description
Description
DebuggerEndpointHelper.getWSEndpoint() treats the /json/list response as
DebuggableEndpointData[] without validating its contents.
When the response contains one or more targets but the selected target does not
have a valid webSocketDebuggerUrl, the method can return undefined despite
declaring a Promise<string> return type.
Actual behavior
The target list is non-empty, so the first item is selected and its missing
webSocketDebuggerUrl is returned as undefined.
This violates the method's Promise contract and can cause failures
later in the debugging flow.
Expected behavior
Only targets with a non-empty string webSocketDebuggerUrl should be considered
valid.
Invalid targets should be skipped.
The first valid target should be selected.
The existing Metro fallback should be attempted when the primary list has no
valid targets.
A clear error should be thrown when no valid target can be found.
- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 295
- Avg merge
- 11h 17m
- Merged PRs (30d)
- 24
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/vscode-react-native
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
microsoft/vscode-react-native#2951 ·
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/vscode-react-native#2945 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoft/vscode-react-native#2933 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/vscode-react-native#2914 ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 72/100
microsoft/vscode-react-native#2957 ·
All issues in microsoft/vscode-react-native
Similar issues
-
comp/desktop P3 type/bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
NousResearch/hermes-agent#118866 ·
-
Browser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
getsentry/sentry-javascript#24577 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
agilepathway/label-checker#640 ·
-
Plugin stuck at "loading" on DSH 0.1.6-alpha.2 — turnTail list slot registration missing options.id Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
chrisparsons83/flexspotff#153 ·