[Feature] Source map read errors are silently swallowed during source map conversion
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript, vscode
- Domain
- developer-experience, devtools
Research direction
Start at SourceMapsCombinator.convert and inspect its call to getSourceMapConsumerFrom(file), focusing on how loading and parsing failures are handled. Confirm the change preserves successful source map accumulation while allowing read or parse errors to reach the caller; validate with the repository's relevant source map conversion checks if available.
Written by the indexing model from the issue text.
Description
Description
SourceMapsCombinator.convert wraps source map loading in a try/finally block and returns the accumulated result from finally.
A return statement inside finally overrides exceptions thrown while reading or parsing a source map. As a result, missing files, permission failures, and malformed source maps are silently treated as if no source map were available.
Expected behavior
Errors raised while reading or parsing a source map should propagate to the caller so that the conversion failure can be diagnosed and handled appropriately.
Actual behavior
The exception is suppressed and conversion either continues or returns the original bundle source map. This can result in incorrect breakpoint or stack-frame mapping without exposing the underlying cause.
Proposed fix
Remove the try/finally wrapper and return normally after loading the source map consumer:
const consumer = this.getSourceMapConsumerFrom(file);
if (consumer) {
result[file] = consumer;
}
return result;- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 295
- Avg merge
- 11h 17m
- Merged PRs (30d)
- 24
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/vscode-react-native
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
microsoft/vscode-react-native#2951 ·
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/vscode-react-native#2945 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoft/vscode-react-native#2933 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
microsoft/vscode-react-native#2929 ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 72/100
microsoft/vscode-react-native#2957 ·
All issues in microsoft/vscode-react-native
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
fullcalendar/fullcalendar#8106 ·