Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

mergebot "unreviewed" handling for unblessed PRs

Open
#1,229 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
typescript

Research direction

Start by tracing mergebot's "unreviewed" handling for unblessed PRs and the shared notification path described in the report. Compare PRs with owner approval that still await DT maintainer approval, then define separate handling so reviewed PRs no longer notify every package owner; confirm the board visibility and notification behavior.

Written by the indexing model from the issue text.

Description

For PRs that require maintainer approval, owner approval does not prevent mergebot from marking a PR as "unreviewed" if still waiting on a DT maintainer.

This isn't the end of the world from the perspective of visibility on the DT board, but the notification logic is the same, and comments a notification to every package owner despite the PR already having been reviewed. This is an annoyance for critical package maintainers, and confusing for contributors.

It'd be an improvement if this scenario were handled separately.

Dominant language
TypeScript
Stars
422
Forks
237
Avg merge
1d 4h
Merged PRs (30d)
8

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/DefinitelyTyped-tools

All issues in microsoft/DefinitelyTyped-tools

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.