[EventRequest][W1][codeunit][426][Payment Tolerance Management] New event OnBeforePmtTolCBGJnl in procedure PmtTolCBGJnl
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- backend
Research direction
The change belongs in codeunit 426 "Payment Tolerance Management", procedure PmtTolCBGJnl, which the issue quotes in full. Study how other integration events in that codeunit are declared and called with the Result and IsHandled pattern, then add the OnBeforePmtTolCBGJnl local integration event and call it at the top of the procedure. Done when a subscriber can set IsHandled and skip the remaining logic, and the existing tests still pass.
Written by the indexing model from the issue text.
Description
Why do you need this change?
In 4PS Construct we need to skip execution of procedure PmtTolCBGJnl if specific conditions are met. In this case we implement our custom logic.
Describe the request
Dear ALAppExtensions team,
On behalf of 4PS I would like to request integration event 'OnBeforePmtTolCBGJnl' to be added to procedure PmtTolCBGJnl of codeunit 426 "Payment Tolerance Management".
procedure PmtTolCBGJnl(var CBGStatementLine: Record "CBG Statement Line"): Boolean
var
GLSetup: Record "General Ledger Setup";
Customer: Record Customer;
Vendor: Record Vendor;
NewCustLedgEntry: Record "Cust. Ledger Entry";
NewVendLedgEntry: Record "Vendor Ledger Entry";
AppliedAmount: Decimal;
OriginalAppliedAmount: Decimal;
ApplyingAmount: Decimal;
AmounttoApply: Decimal;
PmtDiscAmount: Decimal;
MaxPmtTolAmount: Decimal;
CBGStatementLineApplID: Code[20];
ApplnRoundingPrecision: Decimal;
CBGStatement: Record "CBG Statement";
UseDocumentNo: Code[20];
IsHandled: Boolean;
Result: Boolean;
begin
OnBeforePmtTolCBGJnl(CBGStatementLine, Result, IsHandled);
if IsHandled then
exit(Result);
MaxPmtTolAmount := 0;
PmtDiscAmount := 0;
AppliedAmount := 0;
...
end;
[IntegrationEvent(false, false)]
local procedure OnBeforePmtTolCBGJnl(var CBGStatementLine: Record "CBG Statement Line"; var Result: Boolean; var IsHandled: Boolean)
begin
end;
Provide an implementation (optional)
- I will provide the implementation for this extensibility request
- Dominant language
- AL
- Stars
- 697
- Forks
- 473
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 493
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/BCApps
-
missing-info Team: Finance
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
microsoft/BCApps#12893 · 5 comments ·
Maintainers usually reply within 1 day
-
[W1][Extensibility Request][Subscription Billing] Remove local access from InitTempTable() procedure on page 8025 "Contract Price Update"Possibly taken @business-central-extensibility-bot claimed this 1 day ago. OpenApproved ext-ready-to-implement request-for-external Team: Finance
Difficulty 1/5 Under an hour Newbie friendliness 70/100
microsoft/BCApps#12775 · 2 comments ·
Maintainers usually reply within 1 day
-
[W1][MultiObjects] Output journal lines: event after CheckWhse in codeunits 5406 "Output Jnl.-Expl. Route" and 5510 "Production Journal Mgt"Possibly taken @PredragMaricic claimed this 2 days ago. OpenApproved Team: SCM
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
microsoft/BCApps#12652 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
"Warehouse Request" has wrong Table Relation for "Shipping Agent Service Code"Possibly taken @PredragMaricic claimed this 2 days ago. OpenApproved Team: SCM
Difficulty 1/5 Under an hour Newbie friendliness 75/100
microsoft/BCApps#12623 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
[APAC][Extensibility Request][Report][28026][Financial Analysis Report] Move some variables to protected var for extensibilityPossibly taken @business-central-extensibility-bot claimed this 3 days ago. OpenApproved ext-ready-to-implement request-for-external Team: Finance
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/BCApps#12586 · 1 comment ·
Maintainers usually reply within 1 day
All issues in microsoft/BCApps
Similar issues
-
run_all sleeps after the final job despite documenting delays between jobsPossibly taken @Gambit-Checkmate claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bnv-manager-v2: accept_invite creates the Mailcow domain admin before the commitPossibly taken @myOmikron claimed this today. Openbug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
BUG
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Mai-with-u/MaiBot#2187 ·
Maintainers usually reply within 1 day
-
AG-UI bug pkg:core
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pydantic/pydantic-ai#10538 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
nicolettas-muggelbude/RechnungsFee#448 ·
Maintainers usually reply within 1 day