Discover Filters Half Working

Open Beginner friendly
#3,698 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
67/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
android, c
Domain
mobile

Research direction

Start with the Android Discover Contacts Map View filtering code and compare how it applies the selected node type filter with each Path Hash Size; the issue says List View already behaves correctly. Reproduce with Path Hash Size set to 1-byte, 2-byte, or 3-byte, then verify Users, Repeaters, and Room Servers filter the map instead of showing All.

Written by the indexing model from the issue text.

Description

Using MeshCore v1.50.0 on Android 17

In the "Discover Contacts" > "Map View" window:

  • With Path Hash Size = All, the Filter between All, Users, Repeaters, and Room Servers work.
  • But if Path Hash Size = 1-byte, 2-byte, or 3-byte, then the Filter always shows All even if Users, Repeaters, or Room Servers is selected.

This seems to only affect the Map View; List View seems to behave correctly.

For example, my discover list shows 19 nodes with 1-byte path hash size, but it doesn't filter for Users, Repeaters, or Room Servers.

Image Image Image Image
Dominant language
C
Stars
3.9k
Forks
1.5k
Avg merge
2d 20h
Merged PRs (30d)
36

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from meshcore-dev/MeshCore

All issues in meshcore-dev/MeshCore

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.