[Bug] Delayed neutron precursor data all loads from group 2 in h5 xs generation script
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #579 by @hansenkyle — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
Research direction
Open tools/data_library_generator/neutron/generate.py at the two reported locations, lines 474 and 505, and trace the loops over delayed neutron precursor groups. Check how the generated HDF5 data uses each group's fractions, decay rates, and fission spectra. Update both indices as specified in the issue, then generate data for a fissionable material and confirm the groups no longer all use group 2.
Written by the indexing model from the issue text.
Description
Describe the bug.
In the neutron .h5 cross section generation script generate.py, all delayed neutron fractions and decay rates are identical to each other, since they all read from precursor group 2. See line 474:
for i in range(N_DNP):
idx = 1 + 1 # this should be i+1
data = dnp_block.precursor_group_data(idx)
The issue is also present for the delayed fission spectra at line 505.
Steps to reproduce the bug.
This bug appears when generating h5 data for any fissionable material
What is the expected behavior?
idx should be i+1 (converting zero-indexed python i to one-indexed precursor group, within a for i loop)
How can this issue be closed?
- Fix typo on line 475
- Fix typo on line 505
- Dominant language
- Python
- Stars
- 61
- Forks
- 39
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 21
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mcdc-project/mcdc
-
stale
Difficulty 1/5 Under an hour Newbie friendliness 72/100
mcdc-project/mcdc#486 · 1 comment ·
Maintainers usually reply within 1 day
-
hybrid-methods tallies
Difficulty 5/5 Over a week Newbie friendliness 35/100
mcdc-project/mcdc#590 · 1 comment ·
Maintainers usually reply within 1 day
-
[Feature] Source biasing techniquePossibly taken @nglaser3 claimed this 3 days ago. Openhybrid-methods sources variance reduction
mcdc-project/mcdc#587 · 1 assignee ·
Maintainers usually reply within 1 day
-
[Feature] Combine nuclide_composition and element_composition in MaterialPossibly taken @hansenkyle claimed this 3 days ago. Opencontinuous energy materials
Difficulty 4/5 3-5 days Newbie friendliness 55/100
mcdc-project/mcdc#586 · 1 reaction ·
Maintainers usually reply within 1 day
-
hybrid-methods meshes tallies
Difficulty 5/5 Over a week Newbie friendliness 25/100
mcdc-project/mcdc#584 ·
Maintainers usually reply within 1 day
All issues in mcdc-project/mcdc
Similar issues
-
Project submission:Open
Difficulty 1/5 Under an hour Newbie friendliness 72/100
slavakurilyak/awesome-ai-agents#845 ·
Maintainers usually reply within 1 day
-
tests: pin that the atomic writers in utils/paths.py stage the temporary file in the target's directoryPossibly taken A pull request linked to this issue is open or already merged. Opendifficulty:2 enhancement good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 92/100
MakazhanAlpamys/Soup#2178 ·
Maintainers usually reply within 1 day
-
[BUG] dcg.waggr permutation p-values are folded twice, so near-zero scores get the smallest p-valuesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
scverse/rapids-singlecell#854 ·
Maintainers usually reply within 1 day
-
Slang input: int8_t4_packed and uint8_t4_packed are copied into CrossGLPossibly taken @ninglinLiu claimed this today. Openarea:frontend backend:slang bug direction:input
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
random_elements(unique=True) on an OrderedDict: ZeroDivisionError once only zero weights remain, AssertionError with use_weighting=FalsePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 13 days