dataset.py: unpickle whitelist incomplete for python3.14/numpy1/numpy2 variations
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- numpy, python
- Domain
- computer-vision
Research direction
Start in dataset.py at load_matches and inspect the modules_map used for unpickling. Reproduce the OpenSfM test failure with Python 3.14 and numpy 2.5.0, then update the whitelist for the reported numpy._core.numeric._frombuffer variation and verify the tests no longer fail.
Written by the indexing model from the issue text.
Description
Hi, heads up we're having opensfm tests stutter for python314Packages.opensfm at Nixpkgs, missing numpy._core.numeric._frombuffer in load_matches' modules_map, an attribute which probably originates from numpy2 but I didn't check. Cf. logs under the bottom spoiler at https://github.com/NixOS/nixpkgs/pull/436700#issuecomment-4961931059.
EDIT: Hold on, we're maybe having an automation failure, picking up the wrong tag... The tests ran correctly against https://github.com/mapillary/OpenSfM/commit/238744cdf3b5d50149c50d136a87f7fea25ad5cd, the failure is reproducible for python314Packages.opensfm and numpy at 2.5.0
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 898
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapillary/OpenSfM
-
Potential compatibility issues with matplotlib.cm.get_cmap (Incompatible with Matplotlib 3.9.0)Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Issue with ODMOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
All issues in mapillary/OpenSfM
Similar issues
-
Quantized sample scoring and slicing discard the configured epsilon gapPossibly taken @sylvesterkaczmarek claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
google-deepmind/distrax#364 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 66/100
suitenumerique/conversations#798 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
fabriziosalmi/certmate#1207 ·
Maintainers usually reply within 1 day
-
[work-item] adam-adae-onset-emergence: document the minute-precision datetime coercion (ASTTMF not derivable)Possibly taken @muse-yamaa-bot claimed this today. Openwork-item
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day