Performance profiling results
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- performance
Research direction
Review the profiling image and the reported GetFeature, clipper, LINQ/Select, list sizing, ToList, and ConvertAll hotspots. Before changing anything, turn one hotspot into a reproducible measurement; done would require a scoped optimization with verified profiling results, but this issue does not define a specific target or test.
Written by the indexing model from the issue text.
Description
I was testing my own changes&performance and decided to share this as well.
This frame took 981ms GetFeature takes 153 of that. Few things to note;
- First of all, I thought we were using clipper for 16+ levels. It seems like it's working at 16 as well? Do we need it at 16- levels?
- Yes it's mostly clipper but still there are bunch of easy improvements for slow days
- Where & Select, or let's say linq in general, little slow and makes probably unnecessary allocations
- List size changes are actually costly, I haven't checked this one but at my side, I started calculating the size and creating them with that size which saved me from all those array copying.
- ToList is extremely slow. And it's even following a select statement (for tags). Is ConvertAll slower? (I couldn't re-test as profiler is actually quite slow in deep-profile mode)
I'll post if I can find anything else!
cc @BergWerkGIS
- Dominant language
- C#
- Stars
- 64
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/vector-tile-cs
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
mapbox/vector-tile-cs#47 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mapbox/vector-tile-cs#45 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mapbox/vector-tile-cs#43 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mapbox/vector-tile-cs#39 · 1 comment ·
-
Remove bench fixtures (have been deprecated)May be free again @wilhelmberg claimed this 3196 days ago, and no pull request is open. Open
mapbox/vector-tile-cs#38 · 1 assignee ·
All issues in mapbox/vector-tile-cs
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
MicrosoftLearning/PL-400_Microsoft-Power-Platform-Developer#231 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
joinrpg/joinrpg-net#5313 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day