Bad space utilization when using lots of icons

Open
#63 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
tooling

Research direction

Start by tracing the image-generation entry point and how ShelfPack is used there; the issue specifically asks whether ShelfPack's shrink operation can run while generating the image file. Done means the generated sprite has less unused area while preserving the icons and reducing the ARGB_8888 memory footprint described for Android.

Written by the indexing model from the issue text.

Description

enhancement estimate-4 groomed jira-sync-complete p3

Would it be possible to call ShelfPack's shrink when generating the image file, as currently we're seeing a large unused area of the sprite:
image

Whilst the png will compress the area, it is fully loaded as ARGB_8888 on Android wasting a lot of memory (especially on bigger @2x)

Dominant language
JavaScript
Stars
186
Forks
70
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/spritezero

All issues in mapbox/spritezero

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.