Pin the frame view's state, routine and weather codes
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 77/100
Research direction
Read engine-rs/src/identity_tests.rs and the engine definitions for PState, UnitState, routine codes, weather codes, car direction, and sentinels. Extend the pinned table to list each variant and its code, then check that the test covers all listed mappings and that changes require a FRAME_LAYOUT_VERSION bump.
Written by the indexing model from the issue text.
Description
Deferred from the /gds-code-review pass on #963 slice 1.
engine-rs/src/identity_tests.rs pins every slot offset and record width of the frame view, and FRAME_LAYOUT_VERSION sits in the compat record. Nothing pins what the numbers in those slots mean: the PState and UnitState index maps, the routine codes (1 schoolRun, 2 salesCall), the weather codes (0 clear, 1 cloudy, 2 rain), the car direction encoding, and the -1 and NaN sentinels. Swapping two state indexes keeps every offset and fails no test, yet a host decoding the frame would misread it.
Possible fix: extend the pinned table with these maps (a test that lists each variant and its code), so the layout version has to move with them.
Classification
Permanent engine tooling, no behavior change.
- Dominant language
- TypeScript
- Stars
- 6
- Forks
- 1
- Avg merge
- 8h 44m
- Merged PRs (30d)
- 169
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from maniator/verticopolis
-
bug P3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
maniator/verticopolis#1249 ·
Maintainers usually reply within 1 day
-
enhancement P3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
maniator/verticopolis#1202 ·
Maintainers usually reply within 1 day
-
bug P1
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
maniator/verticopolis#1162 ·
Maintainers usually reply within 1 day
-
enhancement P3 wasm
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
maniator/verticopolis#1151 ·
Maintainers usually reply within 1 day
-
bug P3 wasm
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
maniator/verticopolis#1129 ·
Maintainers usually reply within 1 day
All issues in maniator/verticopolis
Similar issues
-
native
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
prime-radiant-inc/evener#4839 ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
processone/fluux-messenger#1790 ·
Maintainers usually reply within 1 day
-
🛣️ Infrastructure
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
opencrvs/opencrvs-core#14232 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
kunchenguid/gh-axi#220 ·
Maintainers usually reply within 1 day