Investigate SSLPeerUnverifiedException changes in Android 37
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 43/100
Research direction
Start by reviewing the behavior change and test updates in pull request #9515, then inspect the four named call sites: SSLSession.handshake(), RealConnection.isEligible, RetryAndFollowUpInterceptor.isRecoverable(), and retryTlsHandshake(). Check how Android 37 represents SSLPeerUnverifiedException at each point and whether existing tests cover it. Done means the affected behavior is verified and any necessary tests are updated.
Written by the indexing model from the issue text.
Description
We changed some tests in https://github.com/square/okhttp/pull/9515 in reaction to SSLPeerUnverifiedException being a cause and not the thrown exception.
This behavior change could impact other parts of OkHttp:
SSLSession.handshake()catchesSSLPeerUnverifiedExceptionRealConnection.isEligiblecatchesSSLPeerUnverifiedExceptionRetryAndFollowUpInterceptor.isRecoverable()returns false onSSLPeerUnverifiedExceptionretryTlsHandshake()returns false onSSLPeerUnverifiedException
- Dominant language
- Kotlin
- Stars
- 47.1k
- Forks
- 9.3k
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 15
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lysine-dev/okhttp
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
lysine-dev/okhttp#9788 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lysine-dev/okhttp#9761 · 3 comments ·
Maintainers usually reply within 1 day
-
Remove crossinline `addInterceptor` and `addNetworkInterceptor` overloadsMay be free again @Amir-Golmoradi claimed this 7 days ago, and no pull request is open. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 58/100
lysine-dev/okhttp#9779 · 1 comment ·
Maintainers usually reply within 1 day
-
HTTP/2 Data padding is not counted toward the connection flow-control window. This deadlocks connections with peers that pad.May be free again @Amir-Golmoradi claimed this 7 days ago, and no pull request is open. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 67/100
lysine-dev/okhttp#9772 · 6 comments ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
lysine-dev/okhttp#9760 · 3 comments ·
Maintainers usually reply within 1 day
All issues in lysine-dev/okhttp
Similar issues
-
Dev
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ankidroid/Anki-Android#22555 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
core: RAC_LLM_OPTIONS_DEFAULT.min_p disagrees with the IDL's annotated defaultPossibly taken A pull request linked to this issue is open or already merged. Openbug core p3
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
RunanywhereAI/runanywhere-sdks#1083 ·
Maintainers usually reply within 5 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Java and Kotlin (JVM): parse gradle/wrapper/gradle-wrapper.properties with exact line locationsOpenarea: detector eco: java help wanted lane: free-agent roadmap size: S type: parser
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
arminazimi/evergreen#355 ·
Maintainers usually reply within 1 day