MapMask is broken
Open
@ternaus is already working on this.
Since Nov 13, 2019.
Assessment
This issue has not been assessed yet.
Description
bug
I'd like to report the following problems with MapMask:
- It uses
foreground=255, but if you look to the map, you'll notice that white color means background. - Function
is_on_maskis broken because it ignores 3 channels of RGB picture. (Python complains about indexing). The fix would be to check if all channels are white or non-white, like:
mask = np.all(this_mask[py[on_mask], px[on_mask]], axis=-1)
- Dominant language
- Jupyter Notebook
- Stars
- 390
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lyft/nuscenes-devkit
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
lyft/nuscenes-devkit#106 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 20/100
lyft/nuscenes-devkit#105 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
lyft/nuscenes-devkit#104 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
lyft/nuscenes-devkit#103 · 2 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 48/100
lyft/nuscenes-devkit#99 ·