i build librom in windows and i fond a memory leak
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- performance
Research direction
Start in MatrixInterpolator::obtainLambda() and reproduce the issue by repeatedly calling interpolator.interpolate with the shown input. Compare memory behavior around the dposv call and the reported Eigen replacement. Done means repeated interpolation no longer increases memory unexpectedly, with relevant tests or a reproducible check covering the behavior.
Written by the indexing model from the issue text.
Description
when i use
CAROM::Matrix* interpolated_matrix = interpolator.interpolate(&desired_point);
Memory increases by 4MB each time it is called.
So i check the code,when call dposv in void MatrixInterpolator::obtainLambda() make it.
so , I replaced dposv with eigen
Eigen::Map<Eigen::MatrixXd> A(B->getData(), gamma_size, gamma_size);
//
Eigen::Map<Eigen::MatrixXd> X(f_T->getData(), gamma_size, num_elements);
//
Eigen::LLT<Eigen::MatrixXd, Eigen::Upper> llt(A);
//
if (llt.info() != Eigen::Success) { /* error */ }
llt.solveInPlace(X);
- Dominant language
- C++
- Stars
- 237
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from llnl/libROM
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Sample mesh manager wrongly (?) assigns boundary labels to boundaryMay be free again @dylan-copeland claimed this 950 days ago, and no pull request is open. Openbug
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 28/100
-
enhancement help wanted
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
sudoevolve/EUI-NEO#80 ·
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31098 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ml-explore/mlx-c#136 ·