Hard-coded values in NNLS solver
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- distributed-systems, performance
Research direction
Start in lib/linalg/NNLS.cpp at lines 66 and 163, then trace how n_proc_max_for_partial_matrix_ and nb affect matrix distribution. Determine why 15 and 3 were chosen and whether users should configure them; the issue is done only when the intended behavior and any required configurability or documentation are agreed and covered appropriately.
Written by the indexing model from the issue text.
Description
Line 66 and 163 of lib/linalg/NNLS.cpp use hard-coded values of n_proc_max_for_partial_matrix_ = 15 and nb = 3, which seem to be used mainly for distributing the matrix.
- There is no sufficient description as to why these values are chosen.
- For better scalability of this solver, shouldn't these values be determined by the users?
- Dominant language
- C++
- Stars
- 236
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from llnl/libROM
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
bug
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 28/100
Similar issues
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 88/100
QuantStack/git2cpp#187 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
mlcommons/mobile_app_open#1182 ·
-
Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
microsoft/winget-cli#6547 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·