Names collision
@pranav-vempati is already working on this.
Since Nov 10, 2022.
Assessment
This issue has not been assessed yet.
Description
Hey guys!
This is somehow related with https://github.com/LLNL/libROM/pull/154. You have a folders structure/naming problem. To explain that, let's consider lib/linalg/BasisWriter.h:16:
#include "utils/Database.h"
Since you are using quotes, the compiler is first looking for Database.h on lib/linalg/utils/. When that fails (because such folder does not exist), it start looking all around the include paths. Of course, the probabilities of having some other library with a utils/Database.h header file are large.
That names collision would be a problem while compiling the library, which might be eventually fixed by the user (if he really knows what he is doing). But of course that is unacceptable when installing the library.
The easiest solution is renaming the lib/ folder as libROM/, and replacing those includes (where the relative path is not working) by something like #include "libROM/utils/Database.h". It is still not a perfect solution, since collisions might yet happens with the installed library itself, but it is much safer.
Otherwise, you need to rethink the folders structure, so just subfolders are considered
- Dominant language
- C++
- Stars
- 237
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from llnl/libROM
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Sample mesh manager wrongly (?) assigns boundary labels to boundaryMay be free again @dylan-copeland claimed this 950 days ago, and no pull request is open. Openbug
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 28/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ChicoState/autovalidate#195 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
petercorke/robotics-toolbox-python#709 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 2 days