numlock state always remembered when changed
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
Research direction
Read plugins/keyboard/csd-keyboard-manager.c around line 162 and inspect how the remember-numlock-state dconf option is accessed. Reproduce the NumLock press while watching /home/user/.config/dconf with inotifywait; done means the setting is respected and unnecessary writes no longer occur.
Written by the indexing model from the issue text.
Description
* csd version: 4.8.4+ulyssa
* Distribution: Linux Mint 20.1
* 64 bit
Issue
CSD writes to disk on every press of NumLock.
Steps to reproduce
Press the NumLock and watch the disk operation indicator.
Use sudo inotifywait -m -e modify -r /home/user/.config/dconf to watch the realtime modifications:
/home/user/.config/dconf/ MODIFY user.FRBRZ0
/home/user/.config/dconf/ MODIFY user.FRBRZ0
Expected behaviour
There is an option in dconf: '/org/cinnamon/settings-daemon/peripherals/keyboard/remember-numlock-state', which should be checked before writing to dconf. I can't see any change of CSD behaviour when this option is enabled or disabled.
The actual code from the source file csd-keyboard-manager.c Line: 162 is:
if (numlock_state != manager->priv->old_state) {
g_settings_set_enum (manager->priv->settings,
KEY_NUMLOCK_STATE,
numlock_state);
manager->priv->old_state = numlock_state;
}
Other information
The same behavior can be seen on previous versions of Linux Mint / Cinnamon.
- Dominant language
- C
- Stars
- 70
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linuxmint/cinnamon-settings-daemon
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
linuxmint/cinnamon-settings-daemon#453 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
csd-power segfaults on idle dim when brightness is below minimum-display-brightness (NULL GError)Open
Difficulty 3/5 1-2 days Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
linuxmint/cinnamon-settings-daemon#475 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
linuxmint/cinnamon-settings-daemon#474 · 1 comment ·
All issues in linuxmint/cinnamon-settings-daemon
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
Lakr233/vphone-cli#743 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
libsdl-org/SDL#16584 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
FriendsofECCE/ECCE#519 · 2 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
containers/crun#2415 ·
Maintainers usually reply within 1 day