Please make the assumption that VMs don't need power saving user-configurable
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by locating the VM-detection logic and the power-management settings handling in cinnamon-settings-daemon. Trace how configured display sleep and suspend values are treated for virtual machines; done means those user settings are honored while any VM-specific defaults remain appropriately configurable.
Written by the indexing model from the issue text.
Description
I discovered shortly after posting about my issue with display sleep not working (https://forums.linuxmint.com/viewtopic.php?p=2829603#p2829603) that cinnamon-settings-daemon appears to ignore multiple power management related settings if it detects that the system is a VM.
This represents a fairly large assumption about what a VM is and how it is used. VM displays may or may not also be virtual; they can still very easily be physical displays if the VM uses a physical graphics card. The user may still want display sleep to work, even if they don't want full system suspend. It is also fairly confusing for users since the settings appear in settings panels and appear configurable and like they should work, and then simply are ignored by the daemon that implements them.
It does perhaps seem reasonable for power management settings to default to different values for a VM, and those defaults could be "Never" sleep the display or suspend, but completely ignoring a user's configured settings seems like behavior that's difficult to justify as reasonable. It's unclear to me right now whether a GNOME setting's default can actually be made conditional on a runtime determination like "is VM", but alternatives that achieve this in practice - like doing a one time override of the settings' value at daemon runtime (and then setting a flag to not repeat the override) - seem unequivocally preferable to ignoring the setting completely and would be a good way to roll out a change like this.
Can this please be changed to enable users to make and configure their own decisions about how power management should behave? Thank you!
Edit: I'm also open to submitting a patch for this if it's indicated that one might be accepted.
- Dominant language
- C
- Stars
- 70
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linuxmint/cinnamon-settings-daemon
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
linuxmint/cinnamon-settings-daemon#453 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
linuxmint/cinnamon-settings-daemon#475 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
All issues in linuxmint/cinnamon-settings-daemon
Similar issues
-
bug Component component: net
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
RT-Thread/rt-thread#11913 · 1 comment ·
Maintainers usually reply within 1 day
-
area:docs kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
InauguralSystems/EigenScript#1887 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
containers/crun#2391 ·
Maintainers usually reply within 1 day
-
category:port-update
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
type-bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day