Drop drivine_contains at the spec bump that refuses parameter maps in matched patterns
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Read the listed definitions in drivine/backend/sqlite/sqlite_graph.py, sqlite_cypher_functions.py, and sqlite_cypher_values.py, then find tests that call drivine_contains or contains. Remove the constant, registration, function, documentation line, and any now-unused value helper or tests. Done when no references remain and the shared spec sync handles the matched-pattern refusal.
Written by the indexing model from the issue text.
Description
Follows liberation-data/drivine-cypher-spec#194, which makes the compiler refuse a parameter's map as a matched pattern's properties (MATCH (n $props)), as Neo4j does. That was the only Cypher that compiled to drivine_contains, so once this library takes the spec release with #194, nothing calls the function.
What to drop at that bump:
CONTAINS = "drivine_contains"indrivine/backend/sqlite/sqlite_graph.py:36add(g.CONTAINS, 2, contains)anddef containsindrivine/backend/sqlite/sqlite_cypher_functions.py:64and:103, and the doc line at:8containsindrivine/backend/sqlite/sqlite_cypher_values.py:214, if nothing else calls it- any test that calls them
Nothing to port: the refusal is the shared compiler's, and its refusals.yaml case "Parameter map in a matched pattern" comes with the spec sync.
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 3h 40m
- Merged PRs (30d)
- 219
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from liberation-data/drivine-python
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
liberation-data/drivine-python#529 ·
Maintainers usually reply within 1 day
-
bug post-north-star
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
liberation-data/drivine-python#484 ·
Maintainers usually reply within 1 day
-
Let the SQLite busy timeout be set, as DATABASE_CONNECTION_TIMEOUT sets it in Drivine for TypeScriptOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
liberation-data/drivine-python#463 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
liberation-data/drivine-python#432 · 2 comments ·
Maintainers usually reply within 1 day
-
Docs: drivine4j doesn't read the flat DATABASE_* variables, as 02-connecting.md and design.md sayOpendocumentation
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
liberation-data/drivine-python#361 ·
Maintainers usually reply within 1 day
All issues in liberation-data/drivine-python
Similar issues
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
aws-samples/sample-spec-driven-presentation-maker#648 ·
Maintainers usually reply within 1 day
-
firestore: enable live window.yaml pipeline system tests once add_window_fields is in productionOpen
Difficulty 1/5 Under an hour Newbie friendliness 64/100
googleapis/google-cloud-python#19115 ·
Maintainers usually reply within 2 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day