IndexManager.drop on Neo4j leaves an index of another name over the same properties, dropping only Drivine's name
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Start with drivine/schema/index_manager.py at IndexManager.drop and its sync copy; compare the range, text, and vector index handling with the full-text path. Port the test described from liberation-data/drivine#716: create a range index under another name, call drop, and check SHOW INDEXES. Done means that index no longer appears.
Written by the indexing model from the issue text.
Description
Port of liberation-data/drivine#716.
What happens here. On Neo4j, IndexManager.drop (drivine/schema/index_manager.py:120, and its sync copy) finds the index, but drops a range, text or vector index by Drivine's own name for it (self._statements(held, "drop")). Only a full-text index is dropped by found.name. So an index over the same label and properties, made under another name, is found but not dropped, and no error is raised.
drivine4j drops what it found, by the existing item's name (IndexManager.kt:205, :298, narrowTo(existing, spec)).
Fix. Drop by found.name for every kind on engines that name their indexes. Port the test from liberation-data/drivine#716: make a range index under another name, drop it, and check SHOW INDEXES no longer lists it.
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 3h 40m
- Merged PRs (30d)
- 219
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from liberation-data/drivine-python
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
liberation-data/drivine-python#529 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
liberation-data/drivine-python#504 · 1 comment ·
Maintainers usually reply within 1 day
-
Let the SQLite busy timeout be set, as DATABASE_CONNECTION_TIMEOUT sets it in Drivine for TypeScriptOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
liberation-data/drivine-python#463 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
liberation-data/drivine-python#432 · 2 comments ·
Maintainers usually reply within 1 day
-
Docs: drivine4j doesn't read the flat DATABASE_* variables, as 02-connecting.md and design.md sayOpendocumentation
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
liberation-data/drivine-python#361 ·
Maintainers usually reply within 1 day
All issues in liberation-data/drivine-python
Similar issues
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
aws-samples/sample-spec-driven-presentation-maker#648 ·
Maintainers usually reply within 1 day
-
firestore: enable live window.yaml pipeline system tests once add_window_fields is in productionOpen
Difficulty 1/5 Under an hour Newbie friendliness 64/100
googleapis/google-cloud-python#19115 ·
Maintainers usually reply within 2 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day