Propagate either forget or prune failure from cleanup
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 86/100
Research direction
Start in src/restic_compose_backup/cli.py at cleanup() and trace how maintenance() uses its return value. Check the failed-forget/successful-prune and successful-forget/failed-prune cases, then verify that maintenance reports failure whenever either cleanup operation fails.
Written by the indexing model from the issue text.
Description
In src/restic_compose_backup/cli.py, cleanup() returns forget_result and prune_result. Since restic uses zero for success, this expression returns zero whenever either operation succeeds. For example, a failed forget followed by successful prune is reported as success, so maintenance() does not raise or alert for the failed retention step. Please return a failure when either operation fails.
- Dominant language
- Python
- Stars
- 181
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lawndoc/stack-back
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
lawndoc/stack-back#123 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
lawndoc/stack-back#122 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
lawndoc/stack-back#120 ·
-
Maintenance QuestionOpen
Difficulty 1/5 Under an hour Newbie friendliness 20/100
lawndoc/stack-back#119 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
lawndoc/stack-back#115 ·
All issues in lawndoc/stack-back
Similar issues
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
python-version
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
bug javascript P2-medium python release:v3.1
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
adrirubio/claude-deck#546 ·
Maintainers usually reply within 1 day
-
area: desktop area: website priority: P2 type: feature
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
appandflow/stim#3411 · 1 comment ·
Maintainers usually reply within 1 day