perf: row-id index fragments added after dataset_version are dropped by freshness checks
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by tracing fresh_fragments and build_provenance in rust/lance/src/index.rs, then compare their freshness logic with the bitmap updates in rust/lance-table/src/transaction/index_maintenance.rs and manifest_build.rs; #10090 gives the intended semantics. Find and run the existing tests for FRI freshness, segment merges, and staged commits; done means fragments added for rows from covered fragments remain fresh when no indexed field changed.
Written by the indexing model from the issue text.
Description
With stable row ids, some operations add new fragment ids to a row-id-domain index's fragment_bitmap without changing dataset_version:
- an update that moves rows to new fragments (
register_pure_rewrite_rows_update_frags_in_indices,rust/lance-table/src/transaction/index_maintenance.rs) - a non-deferred compaction (
recalculate_fragment_bitmapin the Rewrite arm ofmanifest_build.rs)
Results stay correct. But those fragments didn't exist at the segment's dataset_version, so freshness checks that trace fragments back to that version can't find them and drop them:
fresh_fragments/build_provenance(rust/lance/src/index.rs)prune_stale_segment_coveragewithprune_historically_missing
That happens during segment merges or staged commits whenever an FRI applies. The affected rows then fall back to flat scans.
Expected (per #10090): for row-id-domain indices the bitmap means "fragments whose rows, by stable row id, are represented", and the watermark applies to row values. Freshness checks should treat a fragment added this way as fresh if its rows came from covered fragments and no indexed field changed.
Related: #9543.
- Dominant language
- Rust
- Stars
- 7.2k
- Forks
- 900
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 366
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lance-format/lance
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 78/100
lance-format/lance#10225 ·
Maintainers usually reply within 3 days
-
feature performance
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
lance-format/lance#10137 ·
Maintainers usually reply within 3 days
-
After initialize_mem_wal, every FTS query logs "ERROR Index __lance_mem_wal has no fields"Possibly taken @lance-gatefixer claimed this 23 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
lance-format/lance#9655 ·
Maintainers usually reply within 3 days
-
Upgrade DataFusion for the unparser stack-overflow fixMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
lance-format/lance#8225 ·
Maintainers usually reply within 3 days
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 84/100
lance-format/lance#6425 · 2 comments ·
Maintainers usually reply within 3 days
All issues in lance-format/lance
Similar issues
-
Small glitchOpenpriority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
storytold/photocraft#9538 ·
Maintainers usually reply within 1 day
-
bug P2 rust
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
jscott3201/rusty-bacnet#2085 ·
Maintainers usually reply within 1 day
-
area:tag area:tag---json---markdown--n bug factory:dogfood factory:triaged persona:scripter platform:linux-cloud priority:p3 type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
gitbutlerapp/grit#1940 · 1 comment ·
Maintainers usually reply within 1 day
-
Inconsistent case in names for Windows installation packages compared to all other assetsPossibly taken A pull request linked to this issue is open or already merged. Openarea:ui bug in progress needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 65/100
bherbruck/solvecraft#6769 · 2 comments ·