validator: accept a JSON produceBlockV3 answer, so proposals work behind blobber
Maintainers usually reply within 6 days
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 30/100
Research direction
Start in crates/validator/src/beacon_node/http.rs at produce_block, read_ssz and get_ssz, and read its doc comment about there being no JSON path for a block. Follow the produceBlockV3 response types to see where version, execution_payload_blinded and data (fork BlockContents or blinded block) would be deserialized, then add a Content-Type dispatch and the new Accept header. Done means a JSON answer from a blobber-style proxy is decoded and the proposal succeeds, with the get_ssz doc rewritten. Note pull request #862 is already open against this, so coordinate before starting.
Written by the indexing model from the issue text.
Description
Problem. The validator client cannot propose behind ethereum-package's blobber.
- Blobber sits between a validator client and its beacon node. On
/eth/v2/validator/blocks/{slot}and/eth/v3/validator/blocks/{slot}it rewritesAccepttoapplication/jsonbefore forwarding (validator_proxy/proxy.goat marioevz/blobber v1.1.0, the version the package pins). produce_block(crates/validator/src/beacon_node/http.rs) asks for SSZ only, andread_sszrefuses any other content type with "asked for SSZ, node answered with application/json".- So every proposal by an ethlambda validator client behind blobber fails.
ethereum-package's add-ethlambda branch (ethpandaops/ethereum-package#1515) therefore refuses blobber_enabled when the validator client is ethlambda, while still allowing an ethlambda beacon node behind blobber.
get_ssz's doc says why only SSZ is named: "there is no JSON path for a block". That is the gap.
Fix.
- Decode a JSON answer to
produceBlockV3: theversionfield,execution_payload_blinded, the values, anddataas the fork'sBlockContentsor blinded block. Fall back on theEth-Consensus-VersionandEth-Execution-Payload-Blindedheaders when the body's fields are missing. - Send
Accept: application/octet-stream;q=1.0,application/json;q=0.9and dispatch on the answer'sContent-Type, so a node or proxy that answers JSON still gets the proposal through. - Rewrite the
get_sszdoc to match.produceBlockV4(gloas) is not intercepted by blobber and can stay SSZ-only. - Once this is in
:unstable, the package's guard can go.
- Dominant language
- Rust
- Stars
- 86
- Forks
- 34
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 77
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/ethlambda
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#850 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#777 · 1 reaction ·
Maintainers usually reply within 6 days
-
Run all gossip validation testsMay be free again @dicethedev claimed this 9 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lambdaclass/ethlambda#725 · 2 comments ·
Maintainers usually reply within 6 days
-
Handle malformed DB dataMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#529 · 4 comments ·
Maintainers usually reply within 6 days
-
Document architectural choicesMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#521 · 2 comments ·
Maintainers usually reply within 6 days
All issues in lambdaclass/ethlambda
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
antithesishq/bombadil#473 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
libracoder/kiri#669 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 5 days
-
autofixer: follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
tursodatabase/turso#12217 ·
Maintainers usually reply within 1 day
-
Declare the CMS schema library in the optional recipients extraPossibly taken A pull request linked to this issue is open or already merged. Openarea:python in-progress
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
yhay81/pyropdf#1005 · 2 comments ·
Maintainers usually reply within 1 day