Add a --log-level flag instead of configuring logs through RUST_LOG only

Open
#821 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 6 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
69/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
cli, observability

Research direction

Start in bin/ethlambda/src/main.rs at the beacon, node and validator command definitions, then trace init_node_logging and node_log_filter to see how the default info floor and RUST_LOG directives interact. Add the proposed flag to all three commands while preserving per-target overrides and the gossipsub cap behavior. Done means each command exposes the flag in --help and the selected level sets the filter floor.

Written by the indexing model from the issue text.

Description

Summary

Log verbosity can only be set through RUST_LOG (init_node_logging and node_log_filter, bin/ethlambda/src/main.rs). The default is info, with libp2p_gossipsub capped at error. None of beacon, node or validator takes a log-level flag, so the setting doesn't show up in --help.

Where it shows up

ethereum-package passes Lighthouse (--debug-level), Teku (--logging), Lodestar (--logLevel), Nimbus (--log-level) and Prysm (--verbosity) their log level as a flag. For ethlambda, the launchers in ethpandaops/ethereum-package#1515 set RUST_LOG in the container environment instead. The same goes for docker-compose files, systemd units and anything else that only builds a command line.

Proposal

--log-level <error|warn|info|debug|trace> on all three sub-commands, setting the floor that node_log_filter currently hard-codes as info. RUST_LOG keeps working for per-target directives on top of it, and the gossipsub cap stays unless a directive names that target, as it does now.

Dominant language
Rust
Stars
86
Forks
34
Avg merge
9d 20h
Merged PRs (30d)
77

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lambdaclass/ethlambda

All issues in lambdaclass/ethlambda

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.