storage: a short delta frame or an undecodable block header still panics a state rebuild
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start with beacon_state_delta.rs at unframe and state_writer.rs at reconstruct_beacon_state_bytes and fold_beacon_state_deltas; then trace block slot decoding through store.rs at try_block_slot_in and peek_beacon_block_slot. Check the additional BlockHeader::from_ssz_bytes(..).expect("valid header") reads in store.rs to decide the fix's scope. Done means truncated StateDiffs and BlockHeaders rows read through get_state return errors instead of panicking, with tests covering both cases.
Written by the indexing model from the issue text.
Description
lambdaclass/ethlambda#788 changed get_state's rebuild to return Error::CorruptState, rather than panic, when a stored state, delta or diff does not decode. A few decodes of disk-sourced bytes on the same path still panic. Line numbers are at #788's head (4fe2f243):
- Delta frame header.
beacon_state_delta::unframe(crates/storage/src/beacon_state_delta.rs:111) slicesbytes[0..32],[32..40]and[40..48]without checking the length. AStateDiffsrow shorter than its 48-byte header therefore panics instead of reading back asCorruptState. On the rebuild path it is called byreconstruct_beacon_state_bytes(crates/storage/src/state_writer.rs:548) andfold_beacon_state_deltas(state_writer.rs:601). The writer'snearest_snapshot_root(state_writer.rs:580) calls it too. - Block slot lookup. Every hop of a rebuild reads its slot through
try_block_slot_in(crates/storage/src/store.rs:1121). Its beacon arm,peek_beacon_block_slot(store.rs:1073), indexes the row by its SSZ offset with no bounds check. Its lean arm.expect("valid header")s (store.rs:1132).reconstruct_state's final header read (state_writer.rs:679) does the same.
This was out of #788's scope because these panics already exist on main and that PR's docs name them. The header decode is also not specific to the rebuild:
block_slot,beacon_block_slotandnearest_snapshot_rootshare it.- Four more
BlockHeader::from_ssz_bytes(..).expect("valid header")reads sit elsewhere instore.rs(2702, 3026, 3074, 3138).
Making only the rebuild tolerate a corrupt header row would leave the next header read panicking. #306 is related but covers backend Results swallowed by .expect(), not bytes that read back fine and then fail to decode.
A fix:
- Add a
try_unframe(split_at_checked(48)) whose error the rebuild maps toCorruptState, and keepunframeas the panicking wrapper for frames the writer just built. - Add a fallible beacon slot peek and lean header decode, so that
try_block_slot_inreturns the crate'sErrorwith a decode failure asCorruptState(or a newCorruptBlockHeader { root }). - Decide whether the other header reads follow.
- Tests: a truncated
StateDiffsrow and a truncatedBlockHeadersrow each read back fromget_stateas an error, not a panic.
- Dominant language
- Rust
- Stars
- 86
- Forks
- 34
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 77
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/ethlambda
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#850 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#777 · 1 reaction ·
Maintainers usually reply within 6 days
-
Run all gossip validation testsMay be free again @dicethedev claimed this 9 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lambdaclass/ethlambda#725 · 2 comments ·
Maintainers usually reply within 6 days
-
Handle malformed DB dataMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#529 · 4 comments ·
Maintainers usually reply within 6 days
-
Document architectural choicesMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#521 · 2 comments ·
Maintainers usually reply within 6 days
All issues in lambdaclass/ethlambda
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
antithesishq/bombadil#473 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
libracoder/kiri#669 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 5 days
-
autofixer: follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
tursodatabase/turso#12217 ·
Maintainers usually reply within 1 day
-
Declare the CMS schema library in the optional recipients extraPossibly taken A pull request linked to this issue is open or already merged. Openarea:python in-progress
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
yhay81/pyropdf#1005 · 2 comments ·
Maintainers usually reply within 1 day