Warm-up proposer preferences are gossiped before peers subscribe to the gloas topics

Open
#794 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 6 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
22/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
networking

Research direction

The gossip path is in swarm_adapter.rs, where the publish error is logged only at debug; that is the first place to change the level to warn. The warm-up behaviour involves the gloas topic subscription timing and the pooled proposer preferences, which the payload does not locate in code. Done means failed publishes surface at warn and the fork-boundary republish or retry path is decided and covered by a test.

Written by the indexing model from the issue text.

Description

From the epoch before gloas, the validator client publishes proposer preferences for the first gloas epoch (#707). On a network with Lighthouse, those warm-up preferences reach no peer:

  • ethlambda's beacon node joins the gloas topics an epoch before the fork and gossips each accepted preference at once;
  • Lighthouse subscribes to them only 2 slots before the fork.

On #707's devnet (gloas at epoch 6), no Lighthouse node and no builder saw any of the warm-up preferences. None of our validators had a preference for the first gloas epoch, so builders' bids for those slots were ignored.

Nothing sends them again

  • The validator client takes the 200 as delivered. #707's once-an-epoch re-send does not help: the node answers an identical entry with 200 and does not republish it.
  • The node logs Published proposer preferences to gossipsub at info even when the publish fails. The publish error is logged only at debug (swarm_adapter.rs).

Possible fixes

  • Republish the pooled preferences for the fork epoch at the fork boundary, or once the gloas topics have peers.
  • Have the node republish an entry it holds whose earlier publish failed, when the client re-sends it.
  • Publish the warm-up epoch's preferences closer to the fork.

Separately, log a failed gossip publish at warn rather than debug.

Dominant language
Rust
Stars
86
Forks
34
Avg merge
9d 20h
Merged PRs (30d)
77

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lambdaclass/ethlambda

All issues in lambdaclass/ethlambda

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.