Remove the additional explicit wait "hack" in progress bar
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start at pkg/output/tui/progress.go, lines 188-193, and review the current progress-bar handling alongside the linked bubbles progress API. Remove the additional explicit wait without leaving progress bars visibly incomplete; verify the behavior with multiple progress bars.
Written by the indexing model from the issue text.
Description
The additional explicit wait "hack" in the progress bar should be removed. If your UI has a lot of progress bars, this wait will be visible.
But, I don't see a way, with the current API of bubbles' progress, to achieve it otherwise...
Without the wait, we get UI with progress bars that are never 100% completed. See example: https://github.com/knative/client-pkg/pull/162#issuecomment-2013176150
Originally posted by @cardil in https://github.com/knative/client-pkg/pull/162#discussion_r1535599192
- Dominant language
- Go
- Stars
- 387
- Forks
- 279
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from knative/client
-
kn secret create --tls-cert creates the certificate under the wrong keyPossibly taken @RaphaelFakhri claimed this 1 day ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 91/100
Maintainers usually reply within 1 day
-
--node-affinity panics without Type and wipes existing affinity settingsPossibly taken @NopeCharon claimed this 8 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Env vars given with --env/--env-value-from/--env-file are silently dropped when they can't be matched in the command linePossibly taken @NopeCharon claimed this 8 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
[48h Knative] KServe pluginMay be free again @sharmaansh21 claimed this 1071 days ago, and no pull request is open. Openknative48h triage/accepted
knative/client#1866 · 4 comments · 1 reaction · 2 assignees ·
Maintainers usually reply within 1 day
-
CLI: add support for experimental new filters API in triggerMay be free again @JuneOh710 claimed this 1072 days ago, and no pull request is open. Openkind/feature triage/accepted
Difficulty 3/5 1-2 days Newbie friendliness 45/100
knative/client#1833 · 6 comments ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
CycloneDX/cyclonedx-go#304 ·
-
[Bug]: snowflake_share fails to read a share attached to a listing with target accounts ('TARGETED ACCOUNTS' in the "to" column)Possibly taken @akhil9tiet claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
snowflakedb/terraform-provider-snowflake#5366 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
txn2/mcp-data-platform#2493 ·
Maintainers usually reply within 1 day
-
fix(doctor): format MongoDB URI and UNIX socket addresses correctly in doctor diagnostic outputOpenbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oscarbol09/branchbase#178 ·
Maintainers usually reply within 4 days