CLI: add support for experimental new filters API in trigger
Maintainers usually reply within 1 day
@JuneOh710 is already working on this.
Since Nov 29, 2023.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start at the kn trigger create entry point and trace how trigger filters are parsed and sent to the API. Compare the experimental filters API in issue 5204 with existing trigger creation behavior. Done means users can create the new filters through the proposed CLI option, with the resulting trigger accepted by the API.
Written by the indexing model from the issue text.
Description
Feature request
As part of preparing the experimental new filters API to Beta (tracked here: https://github.com/knative/eventing/issues/5204), we should add support to kn to create these filters when creating a trigger.
Use case
With the new filters API entering Beta, more users will want to try it out. It would be convenient for them if they can use kn to create them, instead of being required to use yaml files to try out the new filters.
UI Example
kn trigger create mytrigger --new-filter filtertype=filtervalue
- Dominant language
- Go
- Stars
- 387
- Forks
- 279
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from knative/client
-
kn secret create --tls-cert creates the certificate under the wrong keyPossibly taken @RaphaelFakhri claimed this 1 day ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 91/100
Maintainers usually reply within 1 day
-
--node-affinity panics without Type and wipes existing affinity settingsPossibly taken @NopeCharon claimed this 9 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Env vars given with --env/--env-value-from/--env-file are silently dropped when they can't be matched in the command linePossibly taken @NopeCharon claimed this 9 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
kind/bug lifecycle/stale triage/accepted
Difficulty 3/5 1-2 days Newbie friendliness 35/100
knative/client#1965 · 4 comments ·
Maintainers usually reply within 1 day
-
[48h Knative] KServe pluginMay be free again @sharmaansh21 claimed this 1071 days ago, and no pull request is open. Openknative48h triage/accepted
knative/client#1866 · 4 comments · 1 reaction · 2 assignees ·
Maintainers usually reply within 1 day
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
teradata-labs/loom#574 ·
Maintainers usually reply within 1 day
-
cli: name the CRID when saved link limits fail after publish; soften plain-republish mint warningOpenenhancement pr-polish-followup priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
layervai/qurl-integrations#1994 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
CycloneDX/cyclonedx-go#304 ·
-
[Bug]: snowflake_share fails to read a share attached to a listing with target accounts ('TARGETED ACCOUNTS' in the "to" column)Possibly taken @akhil9tiet claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
snowflakedb/terraform-provider-snowflake#5366 · 2 comments ·
Maintainers usually reply within 1 day