Data entity paths are null when reading zip files with subfolders

Open Beginner friendly
  • Is something wrong?
#385 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
java
Domain
data

Research direction

Start in ReadZipStrategy, specifically the readContent path used for zip input, and trace where the temporary extraction folder is returned versus where ro-crate-metadata.json is resolved inside the subfolder. Compare that return value with the folder containing the metadata file, since callers currently get the root temp folder. Done means data entity path values are populated relative to the resolved crate folder; run the zip-reading tests if present.

Written by the indexing model from the issue text.

Description

When reading a ro-crate from a zip file, and the contents inside the zip file are located in a subfolder, the path field of data entities is always null. This is because ReadZipStrategy#readContent and ReadZipStrategy#readContent always return the root temporary folder and not the resolved folder of the ro-crate-metadata.json.

Dominant language
Java
Stars
5
Forks
4
Avg merge
11h 14m
Merged PRs (30d)
4

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

  • No Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from kit-data-manager/ro-crate-java

All issues in kit-data-manager/ro-crate-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.