KillBillHttpClient failing to deserialize some errors
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start in KillBillHttpClient.java at lines 397, 420, and 492, then inspect BillingException and the response from /plugins/killbill-stripe/checkout. Reproduce the Jackson failure with the reported stack trace and determine how error responses are unmarshaled. Done means the client can unpack this returned error without failing on the stacktrace field.
Written by the indexing model from the issue text.
Description
There seems to be a problem handling some errors, specifically unpacking the returned error. This is the stack track I'm seeing:
org.killbill.billing.client.KillBillClientException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "stacktrace" (class org.killbill.billing.client.BillingException), not marked as ignorable (6 known properties: "className", "message", "causeClassName", "code", "causeMessage", "stackTrace"]) at [Source: (ByteArrayInputStream); line: 1, column: 11023] (through reference chain: org.killbill.billing.client.BillingException["stacktrace"]) at
org.killbill.billing.client.KillBillHttpClient.unmarshalResponse(KillBillHttpClient.java:492) at
org.killbill.billing.client.KillBillHttpClient.deserializeResponse(KillBillHttpClient.java:420) at
org.killbill.billing.client.KillBillHttpClient.throwExceptionOnResponseError(KillBillHttpClient.java:397) at
org.killbill.billing.client.KillBillHttpClient.doPrepareRequestInternal(KillBillHttpClient.java:351) at
org.killbill.billing.client.KillBillHttpClient.doPrepareRequest(KillBillHttpClient.java:298) at
org.killbill.billing.client.KillBillHttpClient.doPost(KillBillHttpClient.java:220) at
org.killbill.billing.client.KillBillHttpClient.doPost(KillBillHttpClient.java:215) at
org.killbill.billing.client.KillBillHttpClient.doPost(KillBillHttpClient.java:211) at
It looks like the response that came back doesn't deserialize into the BillingException class, and jackson is failing. The actual error is something to do with the Stripe plugin, my call was to /plugins/killbill-stripe/checkout and I probably haven't configured Stripe properly. I can go fix that but KillBillHttpClient should unpack the error anyway, and there are possibly other cases where the returned error doesn't fit.
This is on killbill-client-java-1.2.1
- Dominant language
- Java
- Stars
- 35
- Forks
- 68
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from killbill/killbill-client-java
-
Migrate away from Joda-Time to java.timeMay be free again @sbrossie claimed this 269 days ago, and no pull request is open. Openenhancement
killbill/killbill-client-java#144 · 1 comment · 1 assignee ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
killbill/killbill-client-java#140 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
killbill/killbill-client-java#136 · 7 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
killbill/killbill-client-java#135 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
killbill/killbill-client-java#131 · 1 comment ·
All issues in killbill/killbill-client-java
Similar issues
-
component/data-layer
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
-
RegistryExceptionHandler uses self-referencing basePackageClasses instead of a controller classOpenbug finsim-registry good-first-issue
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
? - Needs Triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
NVIDIA/cudf-spark#17063 ·
Maintainers usually reply within 2 days
-
status:pending type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100