KillBillHttpClient failing to deserialize some errors

Open
#87 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
api

Research direction

Start in KillBillHttpClient.java at lines 397, 420, and 492, then inspect BillingException and the response from /plugins/killbill-stripe/checkout. Reproduce the Jackson failure with the reported stack trace and determine how error responses are unmarshaled. Done means the client can unpack this returned error without failing on the stacktrace field.

Written by the indexing model from the issue text.

Description

There seems to be a problem handling some errors, specifically unpacking the returned error. This is the stack track I'm seeing:

org.killbill.billing.client.KillBillClientException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "stacktrace" (class org.killbill.billing.client.BillingException), not marked as ignorable (6 known properties: "className", "message", "causeClassName", "code", "causeMessage", "stackTrace"]) at [Source: (ByteArrayInputStream); line: 1, column: 11023] (through reference chain: org.killbill.billing.client.BillingException["stacktrace"]) at 
org.killbill.billing.client.KillBillHttpClient.unmarshalResponse(KillBillHttpClient.java:492) at 
org.killbill.billing.client.KillBillHttpClient.deserializeResponse(KillBillHttpClient.java:420) at 
org.killbill.billing.client.KillBillHttpClient.throwExceptionOnResponseError(KillBillHttpClient.java:397) at 
org.killbill.billing.client.KillBillHttpClient.doPrepareRequestInternal(KillBillHttpClient.java:351) at 
org.killbill.billing.client.KillBillHttpClient.doPrepareRequest(KillBillHttpClient.java:298) at 
org.killbill.billing.client.KillBillHttpClient.doPost(KillBillHttpClient.java:220) at 
org.killbill.billing.client.KillBillHttpClient.doPost(KillBillHttpClient.java:215) at 
org.killbill.billing.client.KillBillHttpClient.doPost(KillBillHttpClient.java:211) at

It looks like the response that came back doesn't deserialize into the BillingException class, and jackson is failing. The actual error is something to do with the Stripe plugin, my call was to /plugins/killbill-stripe/checkout and I probably haven't configured Stripe properly. I can go fix that but KillBillHttpClient should unpack the error anyway, and there are possibly other cases where the returned error doesn't fit.

This is on killbill-client-java-1.2.1

Dominant language
Java
Stars
35
Forks
68
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from killbill/killbill-client-java

All issues in killbill/killbill-client-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.