API classes' constructors using the default KillBillHttpClient constructor cause 404 because of bad url formatting
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start with KillBillHttpClient.getURI() and the default constructors used by API classes such as TenantApi. Reproduce a request without the killbill.url system property, then verify that the constructed URL no longer contains the extra slash and that the request does not return 404.
Written by the indexing model from the issue text.
Description
So API classes (TenantApi for instance) have default constructors that call the default constructor of KillBillHttpClient. The latter relies on system properties or fallback values to init some fileds namely the KillBillHttpClient's kbServerUrl field, so if the system property "killbill.url" isn't set, the fallback value "http://127.0.0.1:8080/" is used instead and since each api has a uri(path) looking like this "/1.0/kb/tenants" , so this line
"u = new URI(String.format("%s%s", this.kbServerUrl, url));" in KillBillHttpClient.getURI() is causing the url used in request to look like this "http://127.0.0.1:8080//1.0/kb/tenants" (notice the // after port), this is causing every request to return null (404 not found) ,as a fix when I set the system property killbill.url to "http://127.0.0.1:8080", requests are successful !
#version1.3.8
- Dominant language
- Java
- Stars
- 35
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from killbill/killbill-client-java
-
enhancement
killbill/killbill-client-java#144 · 1 comment · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
killbill/killbill-client-java#136 · 7 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
killbill/killbill-client-java#135 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
killbill/killbill-client-java#131 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
killbill/killbill-client-java#130 ·
All issues in killbill/killbill-client-java
Similar issues
-
bug untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
opensearch-project/ml-commons#5094 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
emitter:client:csharp feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
affects/8.10 affects/8.9 component/clients kind/bug likelihood/mid severity/mid
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Two open-case totals on one screen: the Programs tile says 15,858 and the nav badge says 15,868 Openbug frontend maui-pilot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100