Dark mode: Delete confirmation button is white text on a white button

Open Beginner friendly
  • Is something wrong?
#213 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
swift
Domain
desktop

Research direction

The report identifies ConfirmDialog and its destructive confirmation button. Read that component’s variant="primary" styling and compare it with the listed overrides; confirm the button’s computed colors in light and dark mode. Done when the confirm button is readable in both themes for destructive confirmations.

Written by the indexing model from the issue text.

Description

What happened?

In dark mode the confirm dialog's confirm button is unreadable: white text on a near-white button. In light mode the same dialog is fine (white text on black). It reproduces on any destructive confirmation, e.g. deleting a model.

Steps to reproduce

  1. Set SpeakType (or the OS) to dark mode.
  2. Go to AI Models and click the trash icon on a downloaded model.
  3. Look at the "Delete" button in the "Delete Whisper Base?" dialog.

Which system? Windows

System version: Windows 11 26H2

SpeakType version: 2.0.0

Which model were you using? Whisper Base

Anything else?

ConfirmDialog layers bg-danger text-white hover:bg-danger hover:opacity-90 dark:text-white over variant="primary". bg-danger and bg-primary have the same specificity, so bg-primary wins the cascade (black in light mode, #fafafa in dark), while dark:text-white is a [data-theme="dark"] descendant rule and outranks text-on-primary — white on white. The intended red never actually rendered in light mode either.

Fix: remove those overrides (and the unused destructive prop) so the button uses the primary fill. Verified computed styles: light #0a0a0a bg / #ffffff text, dark #fafafa bg / #0a0a0a text. Screenshots attached.

Image Image
Dominant language
Swift
Stars
540
Forks
74
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from karansinghgit/speaktype

All issues in karansinghgit/speaktype

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.