Feature request: Pass the empty parameter to custom editors
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start in src/utils/editor.js and compare the custom editor call with the native text editor's use of empty. Pass the parameter through so custom editors can choose between an empty string and the existing cell value; done when the custom editor receives it and can support the same behavior.
Written by the indexing model from the issue text.
Description
Feature request: Pass the empty parameter to custom editors
Hi,
In src/utils/editor.js, the custom editor is currently called without the empty parameter:
obj.options.columns[x].type.openEditor(
cell,
obj.options.data[y][x],
parseInt(x),
parseInt(y),
obj,
obj.options.columns[x],
e
);
However, the native text editor uses empty to determine whether to initialize the editor with an empty string or the existing cell value:
const value = empty == true ? '' : obj.options.data[y][x];
Could you please pass the empty parameter to the custom editor as well, so custom editors can support the same behavior as the native text editor?
Thanks!
- Dominant language
- JavaScript
- Stars
- 7.2k
- Forks
- 890
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jspreadsheet/ce
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
jspreadsheet/ce#1804 ·
-
ts: Misplacement of getConfig in Plugin interfacePossibly taken @YuEfSaEDU claimed this 23 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 85/100
jspreadsheet/ce#1803 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jspreadsheet/ce#1800 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
jspreadsheet/ce#1788 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
jspreadsheet/ce#1699 · 1 comment ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
yjh051108/dsh-routing-suite#227 ·
-
needs-triage release-watch
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dusk-network/exu#17 ·
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 91/100
githubnext/gh-aw-workshop#4458 ·
Maintainers usually reply within 1 day
-
Add: CartoonitoOpencheck:failed feeds:add
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
iptv-org/database#37390 · 1 comment ·
Maintainers usually reply within 9 days