ts: Fix incorrect location of plugins in type definitions (`WorksheetOptions` -> `SpreadsheetOptions`)

Open Beginner friendly
#1,804 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
frontend

Research direction

Start in dist/index.d.ts at lines 1124–1127 and inspect the WorksheetOptions and SpreadsheetOptions definitions. Confirm the type declaration reflects the issue's intended configuration level, then verify that the TypeScript definitions expose plugins under SpreadsheetOptions rather than WorksheetOptions.

Written by the indexing model from the issue text.

Description

In the TypeScript type definitions, plugins is currently defined under WorksheetOptions. However, this appears to be incorrect as plugins should be configured at the spreadsheet level (SpreadsheetOptions).

https://github.com/jspreadsheet/ce/blob/a82cb27726442dc50601183d2d943491bf531835/dist/index.d.ts#L1124-L1127

Dominant language
JavaScript
Stars
7.2k
Forks
890
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jspreadsheet/ce

All issues in jspreadsheet/ce

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.