[Memory] Add comprehensive tests for llama_memory_recurrent state operations
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
Research direction
Start by reading src/llama-memory-recurrent.h and src/llama-memory-recurrent.cpp to understand the state operations and cell metadata. Add tests/test-memory-recurrent.cpp covering write/read roundtrips, partial sequence operations, metadata persistence, multiple sequences, and error paths. Done means the requested operations are covered and coverage of llama-memory-recurrent.cpp exceeds 80%.
Written by the indexing model from the issue text.
Description
Summary
The recurrent memory implementation (src/llama-memory-recurrent.cpp) needs comprehensive tests for state operations.
Current State
llama_memory_recurrentimplements thellama_memory_iinterface for RNN-based models (Mamba, etc.)- Has state write/read methods but limited test coverage
Missing Test Coverage
- State Write/Read roundtrip: Verify
state_write()followed bystate_read()preserves cell data - Partial sequence operations: Test
seq_rm,seq_cp,seq_keepwith various position ranges - Cell metadata: Verify
pos,src,src0,tailfields are correctly persisted - Multi-sequence handling: Test with
n_seq_max > 1
Acceptance Criteria
- Add test file
tests/test-memory-recurrent.cpp - Achieve >80% coverage of
llama-memory-recurrent.cpp - Test both successful operations and error paths
Related Files
src/llama-memory-recurrent.hsrc/llama-memory-recurrent.cpp
- Dominant language
- C++
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jose-compu/funes.cpp
-
stale
Difficulty 5/5 Over a week Newbie friendliness 25/100
jose-compu/funes.cpp#12 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 52/100
jose-compu/funes.cpp#11 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 48/100
jose-compu/funes.cpp#10 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 55/100
jose-compu/funes.cpp#9 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 45/100
jose-compu/funes.cpp#8 ·
All issues in jose-compu/funes.cpp
Similar issues
-
area/actorsystem bug tsan
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ydb-platform/ydb#54282 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 1/5 Under an hour Newbie friendliness 90/100
project-chip/connectedhomeip#74434 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
tenstorrent/tt-metal#58057 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
maplibre/maplibre-native#4690 ·
Maintainers usually reply within 1 day
-
comp-query-execution
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ClickHouse/ClickHouse#122569 ·
Maintainers usually reply within 1 day