[LogosDB] Track and expose memory IDs in search results
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start with tools/cli/cli.cpp lines 1377-1411 and trace the search result handling, including logosdb_result_id() and logosdb_put(). Review the memory chunk path and build_llm_compressed_hint, then update the debug output and search results to carry IDs. Done means the acceptance criteria are met, including documenting ID usage in SPECS.md; LogosDB v0.2.0 is required first.
Written by the indexing model from the issue text.
Description
Update search result handling to expose memory IDs returned by LogosDB v0.2.0.
Background
LogosDB v0.2.0 adds logosdb_result_id() to get row IDs from search results. Currently funes.cpp ignores these IDs.
Proposed Changes
-
Store IDs when teaching
- Keep track of (text_hash -> id) mapping
- Or use sidecar metadata file for ID persistence
-
Include ID in debug output
- When LLAMA_SEMANTIC_MEMORY_DEBUG is set, show:
[semantic-memory] search hit: id=42 score=0.95 text="..."
- When LLAMA_SEMANTIC_MEMORY_DEBUG is set, show:
-
Use IDs for memory provenance
- Track which memories were used in a response
- Enable feedback: "that memory was helpful / not helpful"
Implementation
- Add id field to memory chunk structure
- Update build_llm_compressed_hint to receive IDs
- Update debug logging in search code path
Acceptance Criteria
- Capture and store IDs from logosdb_put()
- Expose IDs in LLAMA_SEMANTIC_MEMORY_DEBUG output
- Include IDs in search results passed to compressor
- Document ID usage in SPECS.md
Dependencies
- Requires LogosDB v0.2.0 (issue #8)
Related Code
- tools/cli/cli.cpp lines 1377-1411 (search result handling)
- Dominant language
- C++
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jose-compu/funes.cpp
-
stale
Difficulty 5/5 Over a week Newbie friendliness 25/100
jose-compu/funes.cpp#12 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 52/100
jose-compu/funes.cpp#11 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 55/100
jose-compu/funes.cpp#9 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 45/100
jose-compu/funes.cpp#8 ·
-
stale
Difficulty 4/5 3-5 days Newbie friendliness 48/100
jose-compu/funes.cpp#7 ·
All issues in jose-compu/funes.cpp
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
KhronosGroup/Vulkan-Tutorial#524 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
microsoft/onnxruntime-genai#2633 ·
Maintainers usually reply within 1 day
-
mapper bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
firebase/firebase-ios-sdk#16718 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
tesseract-ocr/tesseract#4627 ·