doUploadAndExplode doesn't invoke Listener
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
Research direction
Start at the upload(...).withListener(...).doUploadAndExplode(true) entry point and compare its listener handling with doUpload(). Verify that the listener is invoked during the explode flow, and check whether the two methods' return types can be made consistent.
Written by the indexing model from the issue text.
Description
Describe the bug
listener is ignored if uploaded with doUploadAndExplode
To Reproduce
this logs:
var uploaded = artifactory
.repository(repositoryName)
.upload(targetPath, file)
.withListener((bytesRead, totalBytes) -> {
log.debug("Artifactory ({} / {})", bytesRead, totalBytes);
})
.doUpload();
but this doesn't:
var uploaded = artifactory
.repository(repositoryName)
.upload(targetPath, file)
.withListener((bytesRead, totalBytes) -> {
log.debug("Artifactory ({} / {})", bytesRead, totalBytes);
})
.doUploadAndExplode(true);
also it would be more consistent if both methods would have the same return type
Expected behavior
listener should be invoked also with the explode feature.
Versions
- Artifactory Java Client version: 2.19.1
- Operating system: WIN11pro
- Artifactory Version: Enterprise Plus 7.77.14 rev
- Dominant language
- Java
- Stars
- 331
- Forks
- 164
- Avg merge
- 20h 9m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jfrog/artifactory-client-java
-
Timeout unit not specifiedMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jfrog/artifactory-client-java#450 · 2 comments ·
-
question
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
jfrog/artifactory-client-java#375 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
jfrog/artifactory-client-java#448 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
jfrog/artifactory-client-java#447 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
jfrog/artifactory-client-java#445 ·
All issues in jfrog/artifactory-client-java
Similar issues
-
new feature
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
PCL-Community/PCL-CE#3652 ·
Maintainers usually reply within 1 day
-
TaskSecret.vue: replace explicit `any` with real typesPossibly taken @prayas-bit claimed this today. Openarea/frontend good first issue kind/cooldown
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
kestra-io/kestra#20352 · 1 comment ·
Maintainers usually reply within 1 day