Timeout unit not specified

Open Beginner friendly
#450 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
api

Research direction

Open services/src/main/groovy/org/jfrog/artifactory/client/ArtifactoryClientBuilder.java at the timeout variable around line 74 and inspect how its value is passed or used. Clarify the timeout unit in the relevant code documentation or naming, and consider the issue resolved when a user can determine whether the value is in seconds or milliseconds.

Written by the indexing model from the issue text.

Description

https://github.com/jfrog/artifactory-client-java/blame/631eafcb125bf0b1f2fd562fa474008bbd0ddb46/services/src/main/groovy/org/jfrog/artifactory/client/ArtifactoryClientBuilder.java#L74

There is little to no code documentation and the variable names are also not speaking for themselves. What are the units for the timeout?
Seconds? Milliseconds?

Dominant language
Java
Stars
331
Forks
163
Avg merge
20h 9m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jfrog/artifactory-client-java

All issues in jfrog/artifactory-client-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.