License injection has issues
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- build-system
Research direction
Start with the problems and proposed context in pypa/setuptools#4981, then trace how this skeleton injects licenses during sdist and wheel builds. Confirm whether retrieval and file creation occur in both paths; done means avoiding redundant retrieval and preventing unwanted license files in local builds.
Written by the indexing model from the issue text.
Description
As articulated in pypa/setuptools#4981, there are some outstanding problems with the setuptools-based license injection.
- Injecting the license as a file leaves the file on the file system for the user to wonder why it's there. At the very least, this file should be omitted for local builds. Better would be to have a cleaner way to inject the license during sdist generation.
- The license injection, including the network access, runs when building sdist to wheel, which is redundant and unnecessary. It's a larger problem for setuptools (there are many things that should probably be separated between sdist and wheel builds, but that's a separate issue). At the very least, the license retrieval should happen once for any source tree.
- Dominant language
- No language data
- Stars
- 152
- Forks
- 38
- Avg merge
- 6h 27m
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jaraco/skeleton
-
Difficulty 1/5 Under an hour Newbie friendliness 91/100
-
Difficulty 3/5 1-2 days Newbie friendliness 67/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 32/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
0.kind: bug
Difficulty 1/5 Under an hour Newbie friendliness 82/100
NixOS/nixpkgs#588857 · 1 reaction ·
Maintainers usually reply within 1 day
-
area:ui bug effort:low P2 source:agent
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
MattiaPARRINELLO/backstage#71 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
untemps/svelte-palette#298 ·
-
Retarget the extension to Fallout 10.5Possibly taken @ChrisonSimtian claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100