[Bug]: TypeScript binary downloads resolve JSON success envelopes as files or bytes

オープン
  • 何か問題がありますか？
#7,449 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@stefanielizeth73-art がすでに取り組んでいます。

2026年11月11日 から。

  • #7452 @stefanielizeth73-art による — オープン

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
停滞
技術スタック
node.js, typescript
領域
backend-api-design

調査の方向性

Inspect the TypeScript SDK’s exportOVPack(), backupOVPack() and downloadBytes() paths that call parseResponse<never>(); the issue does not name their source files or tests. Start by locating those methods and the binary response tests. Done means JSON success envelopes raise an SDK protocol error while JSON API errors and successful binary downloads retain their behavior; linked pull request #7452 is already open.

索引モデルが issue の本文から書いたものです。

説明

Issue Origin

Reproduced through the built TypeScript SDK against a local HTTP fixture. The fixture supplies a JSON response; no deployed OpenViking server or model was used.

Bug Description

The TypeScript binary download paths call parseResponse<never>() when a response is JSON. That type argument disappears at runtime: a successful JSON envelope resolves to its result instead of rejecting the unexpected response.

This affects exportOVPack() / backupOVPack() (declared Promise<string>) and downloadBytes() (declared Promise<Uint8Array>). For example, HTTP 200 with Content-Type: application/json and {"status":"ok","result":{"message":"not binary data"}} makes all three methods resolve to the object. The pack methods leave the previous file intact but report a successful download without returning a file path.

Steps to Reproduce
  1. Have a local .ovpack containing known-good-backup.
  2. Serve the JSON envelope above from the pack export/backup endpoint.
  3. Call client.backupOVPack(output) or client.exportOVPack("resources/docs", output).
  4. Return the same response from /api/v1/content/download and call client.downloadBytes("resources/a.bin").
Expected Behavior

JSON API errors retain their existing error code and details. A JSON success envelope at a binary endpoint raises an SDK protocol error, preserving any existing pack. A successful binary response returns the documented file path or bytes.

Actual Behavior

All three methods resolve to {message: "not binary data"}. Neither a completed file download nor a byte result was produced.

Proposed Fix and Compatibility

Keep the current JSON/API-error classification. After its existing parser returns without an error, explicitly reject the unexpected response instead of returning its JSON result. Leave JSON endpoints, snapshot metadata responses and successful binary downloads unchanged. No new API options or dependencies are needed.

OpenViking Version

Current main 32de68480d36593648563f749d9af7a4a817489f, @openviking/sdk 0.1.0 source build.

Runtime / Operating System

Node.js 25.9.0, Windows 11. Python and model backends are not involved.

Additional Context

This complements #7058's JSON envelope shape validation and #7358's Python backup response handling. It concerns an object-shaped JSON success envelope and the TypeScript binary return contract. The investigation and local reproduction were completed with Codex assistance.

主要言語
Python
スター
41.8k
フォーク
3.4k
平均マージ
19時間 29分
マージ済み PR（30日）
500

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

volcengine/OpenViking のほかの issue

volcengine/OpenViking の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。