[Bug]: TypeScript binary downloads resolve JSON success envelopes as files or bytes

Abierto
  • ¿Algo no está bien?
#7,449 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@stefanielizeth73-art ya está trabajando en esto.

Desde el 11/11/2026.

  • #7452 de @stefanielizeth73-art — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
node.js, typescript
Área
backend-api-design

Línea de trabajo

Inspect the TypeScript SDK’s exportOVPack(), backupOVPack() and downloadBytes() paths that call parseResponse<never>(); the issue does not name their source files or tests. Start by locating those methods and the binary response tests. Done means JSON success envelopes raise an SDK protocol error while JSON API errors and successful binary downloads retain their behavior; linked pull request #7452 is already open.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Issue Origin

Reproduced through the built TypeScript SDK against a local HTTP fixture. The fixture supplies a JSON response; no deployed OpenViking server or model was used.

Bug Description

The TypeScript binary download paths call parseResponse<never>() when a response is JSON. That type argument disappears at runtime: a successful JSON envelope resolves to its result instead of rejecting the unexpected response.

This affects exportOVPack() / backupOVPack() (declared Promise<string>) and downloadBytes() (declared Promise<Uint8Array>). For example, HTTP 200 with Content-Type: application/json and {"status":"ok","result":{"message":"not binary data"}} makes all three methods resolve to the object. The pack methods leave the previous file intact but report a successful download without returning a file path.

Steps to Reproduce
  1. Have a local .ovpack containing known-good-backup.
  2. Serve the JSON envelope above from the pack export/backup endpoint.
  3. Call client.backupOVPack(output) or client.exportOVPack("resources/docs", output).
  4. Return the same response from /api/v1/content/download and call client.downloadBytes("resources/a.bin").
Expected Behavior

JSON API errors retain their existing error code and details. A JSON success envelope at a binary endpoint raises an SDK protocol error, preserving any existing pack. A successful binary response returns the documented file path or bytes.

Actual Behavior

All three methods resolve to {message: "not binary data"}. Neither a completed file download nor a byte result was produced.

Proposed Fix and Compatibility

Keep the current JSON/API-error classification. After its existing parser returns without an error, explicitly reject the unexpected response instead of returning its JSON result. Leave JSON endpoints, snapshot metadata responses and successful binary downloads unchanged. No new API options or dependencies are needed.

OpenViking Version

Current main 32de68480d36593648563f749d9af7a4a817489f, @openviking/sdk 0.1.0 source build.

Runtime / Operating System

Node.js 25.9.0, Windows 11. Python and model backends are not involved.

Additional Context

This complements #7058's JSON envelope shape validation and #7358's Python backup response handling. It concerns an object-shaped JSON success envelope and the TypeScript binary return contract. The investigation and local reproduction were completed with Codex assistance.

Lenguaje dominante
Python
Estrellas
41.8k
Forks
3.4k
Merge medio
19 h 29 min
PR fusionados (30 d)
500

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de volcengine/OpenViking

Todos los issues de volcengine/OpenViking

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.