Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

vp run forwards no signal to its task, so stopping vp alone orphans the task

オープン
#3,090 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
30/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
rust
領域
cli

調査の方向性

Start with the comment at crates/vt/src/session/mod.rs:382-388, which says child tasks receive signals from the terminal driver, and trace how vp run spawns tasks and handles signals in the local CLI and the global vp wrapper. Reproduce by running vp run dev and sending SIGTERM to the vp pid alone. The issue is open on a choice between forwarding signals and documenting process-group signalling, so confirm the maintainers' preferred direction before writing code.

索引モデルが issue の本文から書いたものです。

説明

pending triage
Description

vp run <script> forwards no signal to the task it runs. A SIGINT or SIGTERM sent to the vp process alone ends vp, and the script's process keeps running, reparented to init or the user manager. A Ctrl-C in a terminal works only because the terminal sends it to the whole process group. Tools that stop a job by signalling the process they started leave the task running. That includes kill <pid> from a script, a supervisor, or an editor or agent harness that started vp run dev as a background command.

Tested on vite-plus 1.2.0 (global vp and the local CLI), on Linux:

Signal sent to Result
global vp, SIGINT or SIGTERM vp exits; the task keeps running
local CLI, SIGTERM the CLI exits; the task is orphaned
local CLI, SIGINT ignored
the whole process group everything exits

This looks deliberate. vite-task at 9ba4cc93, crates/vt/src/session/mod.rs:382-388, says "Child tasks receive the signal directly from the terminal driver". The docs don't mention it, though.

Suggested solution

Forward SIGINT, SIGTERM and SIGHUP from vp to each running task, then wait for the tasks to exit. This is what npm run does (@npmcli/run-script lib/signal-manager.js), and what Turborepo (turborepo-signals) and concurrently (kill-on-signal.ts) do.

The global vp would also need to pass the signal on to the local CLI it starts.

Alternative

Document that vp run must be stopped by signalling its process group, so that harnesses and scripts can do that.

Additional context

We hit this with a long-running dev script that supervises several servers. Stopping vp alone left all of them running and holding their ports. We now tell agents to signal the script's own process instead.

Validations
  • Read the Contributing Guidelines.
  • Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
  • Check that there isn't already an issue requesting the same feature. I searched vite-plus and vite-task for signal, SIGINT, SIGTERM, kill, orphan and process group.
主要言語
Rust
スター
6.3k
フォーク
283
平均マージ
1日 11時間
マージ済み PR(30日)
200

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

voidzero-dev/vite-plus のほかの issue

voidzero-dev/vite-plus の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。