Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Apply one startup deadline from container start to ready

オープン
  • 何か問題がありますか？
#1,582 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@cristianrgreco がすでに取り組んでいます。

2026年10月12日 から。

  • #1584 @cristianrgreco による — オープン

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
docker, node.js, typescript
領域
backend, testing

調査の方向性

Read generic-container/generic-container.ts at startContainer and reuseContainer, then trace the exposed-port inspection utility and wait-strategy.ts through each strategy and the Kafka, Redpanda, and Couchbase containerStarted hooks. Check the linked dependency issues and the core tests that assert timeout errors. Decide whether image pulling counts toward the shared deadline and coordinate the timeout precedence and hook context; done means all startup phases share one deadline and report the waiting phase and total budget.

索引モデルが issue の本文から書いたものです。

説明

enhancement major

What happens

withStartupTimeout(ms) reads as "the container must be ready within this long". It is applied per phase instead, so start() can take several times longer than the value given before it fails:

  • The image pull has no limit.
  • The port-binding wait has its own fixed 30 second limit, separate from the startup timeout.
  • The wait strategy gets the full timeout, counted from the moment the wait begins.
  • Modules that wait again in containerStarted restart the clock. Kafka and Redpanda apply startupTimeoutMs to a second wait, so a Kafka container with its default of 180 seconds can run for close to 360 before failing.

Expected

One deadline, fixed when the container is started. The port-binding wait, the wait strategy and the hooks each get what is left of it. When it runs out, the error says which phase was waiting and what the total budget was.

Where

  • startContainer and reuseContainer in packages/testcontainers/src/generic-container/generic-container.ts
  • packages/testcontainers/src/generic-container/inspect-container-util-ports-exposed.ts
  • packages/testcontainers/src/wait-strategies/wait-strategy.ts and every strategy
  • containerStarted in the kafka, redpanda and couchbase modules

Notes

  • This cannot be done compatibly. The strategy has to be told the deadline. Passing the remaining time through withStartupTimeout changes the error text, which core tests assert exactly (not accessible after 3000ms), and changes the caller's strategy instance. A new argument to waitUntilReady is an interface change. Hence major.
  • Go gets this from context: each strategy calls context.WithTimeout(ctx, timeout), so the caller's context is the ceiling and a strategy's own timeout can only shorten it.
  • #1494 kept the port-binding limit independent of withStartupTimeout, because tying them together would let each phase use the full timeout. A shared deadline removes that objection.
  • Decide whether the image pull counts towards the deadline.
  • A compatible first step is being prepared separately: the remaining startup time is passed to containerStarted, so module waits after the wait strategy stop restarting the clock.
  • Related: #1446, #1513.

Dependencies

  • Blocked by #1558, #1560: both change what waitUntilReady receives. The deadline should travel in what they add, so the interface changes once.
  • Coordinate with #1523: the precedence between a container timeout and a strategy timeout has to be one rule.
  • Coordinate with #1554: hooks should be given the remaining time through their context.
主要言語
TypeScript
スター
2.6k
フォーク
274
平均マージ
1日 14時間
マージ済み PR（30日）
44

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

testcontainers/testcontainers-node のほかの issue

testcontainers/testcontainers-node の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。