Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Apply one startup deadline from container start to ready

Abierto
  • ¿Algo no está bien?
#1,582 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@cristianrgreco ya está trabajando en esto.

Desde el 12/10/2026.

  • #1584 de @cristianrgreco — abierto

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
docker, node.js, typescript
Área
backend, testing

Línea de trabajo

Read generic-container/generic-container.ts at startContainer and reuseContainer, then trace the exposed-port inspection utility and wait-strategy.ts through each strategy and the Kafka, Redpanda, and Couchbase containerStarted hooks. Check the linked dependency issues and the core tests that assert timeout errors. Decide whether image pulling counts toward the shared deadline and coordinate the timeout precedence and hook context; done means all startup phases share one deadline and report the waiting phase and total budget.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement major

What happens

withStartupTimeout(ms) reads as "the container must be ready within this long". It is applied per phase instead, so start() can take several times longer than the value given before it fails:

  • The image pull has no limit.
  • The port-binding wait has its own fixed 30 second limit, separate from the startup timeout.
  • The wait strategy gets the full timeout, counted from the moment the wait begins.
  • Modules that wait again in containerStarted restart the clock. Kafka and Redpanda apply startupTimeoutMs to a second wait, so a Kafka container with its default of 180 seconds can run for close to 360 before failing.

Expected

One deadline, fixed when the container is started. The port-binding wait, the wait strategy and the hooks each get what is left of it. When it runs out, the error says which phase was waiting and what the total budget was.

Where

  • startContainer and reuseContainer in packages/testcontainers/src/generic-container/generic-container.ts
  • packages/testcontainers/src/generic-container/inspect-container-util-ports-exposed.ts
  • packages/testcontainers/src/wait-strategies/wait-strategy.ts and every strategy
  • containerStarted in the kafka, redpanda and couchbase modules

Notes

  • This cannot be done compatibly. The strategy has to be told the deadline. Passing the remaining time through withStartupTimeout changes the error text, which core tests assert exactly (not accessible after 3000ms), and changes the caller's strategy instance. A new argument to waitUntilReady is an interface change. Hence major.
  • Go gets this from context: each strategy calls context.WithTimeout(ctx, timeout), so the caller's context is the ceiling and a strategy's own timeout can only shorten it.
  • #1494 kept the port-binding limit independent of withStartupTimeout, because tying them together would let each phase use the full timeout. A shared deadline removes that objection.
  • Decide whether the image pull counts towards the deadline.
  • A compatible first step is being prepared separately: the remaining startup time is passed to containerStarted, so module waits after the wait strategy stop restarting the clock.
  • Related: #1446, #1513.

Dependencies

  • Blocked by #1558, #1560: both change what waitUntilReady receives. The deadline should travel in what they add, so the interface changes once.
  • Coordinate with #1523: the precedence between a container timeout and a strategy timeout has to be one rule.
  • Coordinate with #1554: hooks should be given the remaining time through their context.
Lenguaje dominante
TypeScript
Estrellas
2.6k
Forks
274
Merge medio
1 d 14 h
PR fusionados (30 d)
44

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de testcontainers/testcontainers-node

Todos los issues de testcontainers/testcontainers-node

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.